From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id DD0DD91B5
 for <dev@dpdk.org>; Sun,  6 Dec 2015 15:38:52 +0100 (CET)
Received: by wmvv187 with SMTP id v187so133693731wmv.1
 for <dev@dpdk.org>; Sun, 06 Dec 2015 06:38:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=cSFbzSGYC55Ljc7R4d26pFd1sn4vv0a3pXb54xXY+UQ=;
 b=GZKb81fyAjnuwLsJklOmbQDAzE3HG3lDUBdrZMO6I0SGV+3pifc1ADPHDO5a9V1KV6
 HJ5CKghyYvIIzBTNwxcgQlkQy8njj5Kip4C7Rnb+6ppbf0jQ4FTiQkUtnDCtPWE3Ihna
 X+Tl7vNMZoYpocTy6aC6IK1umNwTQ+LJZ8cC1G+nxrHH3WzTSBRPI4P4CAckQDhfPIhs
 86MTIRBBfUzbYVaRZ8Gh6ZbCpQBW65m38jXRiIhIPUixnf0h92F0SCCWg4FZOPp17dsw
 ZkAQu5G4EaB855CkMdmDWmTh5jZ7de8Y3MAjgtcvxlL5gQtUs2J3GWKmQ/wiyahCs+KO
 f3Lg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=cSFbzSGYC55Ljc7R4d26pFd1sn4vv0a3pXb54xXY+UQ=;
 b=huNo1kKG3/6dQib/dlzTwjEmBuKwyISM0Tb2x0UwghOVKGRMmby/MJG5F0oLyb3AP/
 5kXH9ZhLtzTySAk2Jd2v3xLh6fcLzczSrtxjuzUtW/wjAx0wQtk3b9qRxFEO6+eQ9lQb
 uATXWQ+7npH36X/0p/wn7yY2mOTcBKKsR9oHvfFRSRYHL47F3ga4S+xOFcCfKGGLjump
 3juFqqo/ZAxWE0uxd03x00gXevjeEI5mS0skNMU8kLnzgm54oUPZEqlhUXOKYi91jz/k
 J7sBrpVgqRHgNYroIwYbG+8BcIh7xYaD4OGx1uWuAesPxL+IPdRuq2Ffc0/+vAVZLOoW
 js1Q==
X-Gm-Message-State: ALoCoQnB7Pj4LldpbVmU/I66DjZ/8aOXkrUFWPk5p7r3Hip1eFwLL89AZbueoRrWj8QWZDfYq+Dr
X-Received: by 10.28.32.22 with SMTP id g22mr15063756wmg.43.1449412732708;
 Sun, 06 Dec 2015 06:38:52 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id b84sm12199893wmh.15.2015.12.06.06.38.51
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 06 Dec 2015 06:38:51 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Date: Sun, 06 Dec 2015 15:37:41 +0100
Message-ID: <1483331.SImPA21uKy@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1449150668-26017-1-git-send-email-ferruh.yigit@intel.com>
References: <56603A44.7040803@redhat.com>
 <1449150668-26017-1-git-send-email-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] mk: fix compile error and ABI versioning
	for combined shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 14:38:53 -0000

2015-12-03 13:51, Ferruh Yigit:
> Fixes following error (observed when versioning macros used):
>   LD libdpdk.so
>   /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found
>   for symbol <function>@DPDK_x.y
> 
> Also resulting combined library contains symbol version information:
> $ readelf -a build/lib/libdpdk.so | grep rte_eal_ | grep @ | head
>    <...>    GLOBAL DEFAULT   12 rte_eal_alarm_set@@DPDK_2.0
>    <...>    GLOBAL DEFAULT   12 rte_eal_pci_write_config@@DPDK_2.1
>    <...>    GLOBAL DEFAULT   12 rte_eal_remote_launch@@DPDK_2.0
> ...
> 
> Versioning fixed by merging all version scripts into one automatically and
> feeding it to final library.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

> +SYMBOLS=$(grep -h "{" $FILES | sort -u | sed 's/{//')

I think SYMBOLS would be better named as VERSIONS.