From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id AD4FDFE5 for ; Tue, 14 Apr 2015 17:24:53 +0200 (CEST) Received: by wgin8 with SMTP id n8so16015088wgi.0 for ; Tue, 14 Apr 2015 08:24:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Kw+k3SlnokV+EBqlH3BcTDo8AuY35apc+nr4EIg7DK8=; b=lBOHpHdrpdyCXku6zjRbjtboGFxWszaezr+zKpFuIbD6EPSM/YoiM66U6cfHMUt2bx 25jp4rofptSev6aOqVen/5jRWBcH9m11TQiPIRbLO+0MR/PkzlKalrZ8xdgFYAP31Zfo hE1EVvfgnFMt7gmmMDkyF66RR8kQ0d6LLGZqWcs/KfXbzPKK22FyPyOgabYF6I+1Ljsy 4xBMji4z8794C29zkwMPO8sdoC9Ls7YEyHJOwnC3PWrn9tlRYv16B1D9ktJr9b7pju6L OFz9gxC1hx7W8/MSUt4AuT1QNo3sAbjhDDoMnL6MSudA2rmWDxkh3xmTsYD4skLyBxl+ kIuA== X-Gm-Message-State: ALoCoQmnQQW35KH4cDFxWyQsfn917FawEN0aseGtoaVgLvAWwyCc8Y/IJFv26jbXmTnCiAS5h7Jf X-Received: by 10.194.108.9 with SMTP id hg9mr41383625wjb.68.1429025093576; Tue, 14 Apr 2015 08:24:53 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id k6sm17684990wia.6.2015.04.14.08.24.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 08:24:52 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Tue, 14 Apr 2015 17:24:11 +0200 Message-ID: <1483348.C8YyOOilOR@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150414145255.GC3296@bricha3-MOBL3> References: <3571725.20GtF5MAnU@xps13> <2232884.6IKBPajdgE@xps13> <20150414145255.GC3296@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 15:24:53 -0000 2015-04-14 15:52, Bruce Richardson: > On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote: > > When a consensus is done, it must be added with a patch with custom > > checkpatch addition. > > > My personal feeling is that we should try and keep checkpatch modifications to a > minimum. Right now, we can use checkpatch as-is from kernel.org, right? Yes that's something we have to discuss. It should be preferred to avoid "forking" checkpatch. At the moment, I'm using this configuration: options="$options --max-line-length=100" options="$options --show-types" options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ SPLIT_STRING,LINE_SPACING,NEW_TYPEDEFS,COMPLEX_MACRO" linux/scripts/checkpatch.pl $options I would like to submit a script to run checkpatch with DPDK configuration when the coding rules are clear. However, I've already seen some options which are not enough configurable (don't remember which one). For such corner case, I would see 3 solutions (from the most to the least desired): - submit a patch to allow more configuration to kernel.org - give up automatic handling of corner cases - maintain a fork in scripts/ directory