From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EC73DA00C2;
	Tue,  8 Mar 2022 15:04:21 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D5D524068E;
	Tue,  8 Mar 2022 15:04:21 +0100 (CET)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id DE0B84068B
 for <dev@dpdk.org>; Tue,  8 Mar 2022 15:04:20 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 9B91C320070D;
 Tue,  8 Mar 2022 09:04:19 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 08 Mar 2022 09:04:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm1; bh=3OlqkICBk8HsIO
 0c+JLMG1jnfprNqFbrrFWTQiYXd/I=; b=NKW8bgyi3cOscHiJSXEPYLj4kvHsUH
 a4C3WVbJ4jXUAiKdwFisO0bHlPN7MUQa/DAYaLimGg5nOGd6QDegsndFmaGQ+t0j
 Q3Z2c2DeFAcddWLxxwGcMOU9J5s+oqSnAus2rJxAlZOWzn8nyDf5E+vzXADXOgLY
 7P48Sf+DDgXNl05te0ANBtVqK5jBxWqvU5rGM9SR8rEPqkTitFbK34RWXKhSIv3E
 VkQEldJbHOd2uEjmohuO0Ct9ZD8UPqYHOz2OEz3HXK7KPy0oPLsSJ7ODDLh0QcCu
 w9nRFQAgA/VG/AHr9WSrQgmWUoG31zE+lQEkHAeBOLJVRCfwShljRvVw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=3OlqkICBk8HsIO0c+JLMG1jnfprNqFbrrFWTQiYXd
 /I=; b=RqrmfENwlkVyl4geHfIYTv5MaNE7rMsCNnI6desCafFD7rbH7e+QcaSbP
 HRPrjVyaOOI8kSQ+E2kCJBTEOIzIyq/xilpRTtncc1SVhJy72YpJjmbk3nkIUZ92
 DQza7E2feDlgxWIagKSA+ghSLcNeDho+lD/uyc44CkNMEaRNtM5rXcOMxTDlRLZP
 aeP8fsjBUrpASzIIWiv6czlQa9Rq7fe212PmZsV+rS03Oo1DVRk0mqpU7m75XEmr
 R0MDliDDU5zJUpbEXP+2Jus1Wxi0pqrTELxWm9ZqNwGrs9ondr1sbBI6qC49sP8o
 PnUAf8xIj9S4LDpB7yUB6zxekDwnA==
X-ME-Sender: <xms:YWInYoVTTdaKXiPw3u-UnGJz4KQBzhU0Re9zU-W4SRiJDd6oKkYtFg>
 <xme:YWInYskpiFQ1GkeQOjHru5s4ReZgImrhnAH4dH4KuovemY5r2UO2WVCYQ0g-VqB2J
 gIeo0FkRsvoNPa5Tw>
X-ME-Received: <xmr:YWInYsa4MB65H2CU_1z8Yu0p9H-DqP2-Ife8Z3iDkHfGzWlH3Irf68sRRbpCO-LhH-BBJTI4v5ju0x7w-hTIK7jyxw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgheekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:YmInYnX8K_BVfLUpS279YgqFw1QjsIS_puFb6fimvP2c5NJ9u7AZuw>
 <xmx:YmInYilgqzUNfmOLOp0dr0d2U4oWkgF2JrH03WK0_FFuBoEFg4XLzA>
 <xmx:YmInYsdjD4cPJOF5GZJB7RMSy96Whzy9vaV9qoa5ncoKSDKFM6e1KQ>
 <xmx:Y2InYmtBuIpAexUIubl0_JEzmysMli_s3gP9fKiNSQWWA862zLAmhQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 8 Mar 2022 09:04:16 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers
Date: Tue, 08 Mar 2022 15:04:15 +0100
Message-ID: <14835742.EVyyLHbfrO@thomas>
In-Reply-To: <87a6e8hd6f.fsf@mdr78.vserver.site>
References: <20220301165404.18936-1-david.marchand@redhat.com>
 <20220301165404.18936-2-david.marchand@redhat.com>
 <87a6e8hd6f.fsf@mdr78.vserver.site>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

02/03/2022 11:16, Ray Kinsella:
> 
> David Marchand <david.marchand@redhat.com> writes:
> 
> > Convert the existing exception in the ABI script into a libabigail
> > suppression rule.
> >
> > Note: file_name_regexp could be used to achive the same with versions of
> > libabigail < 1.7 but soname_regexp has been preferred here since it is
> > already used with a recent change on common/mlx5.
> >
> > While at it, fix indent from a recent change.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  devtools/check-abi.sh        | 7 -------
> >  devtools/libabigail.abignore | 8 ++++++--
> >  2 files changed, 6 insertions(+), 9 deletions(-)
> >
> 
> Minor niggle that changes to the check-abi.sh script should have been in
> the first patch?

No, first patch is about DLB, second is mlx.

> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Series applied, thanks.