From: Rasesh Mody <rasesh.mody@cavium.com>
To: <ferruh.yigit@intel.com>
Cc: Rasesh Mody <Rasesh.Mody@cavium.com>, <dev@dpdk.org>,
<stable@dpdk.org>, <Dept-EngDPDKDev@cavium.com>
Subject: [dpdk-dev] [PATCH v2 5/5] net/qede: convert few DP_NOTICE and DP_INFO to DP_ERR
Date: Fri, 6 Jan 2017 00:16:49 -0800 [thread overview]
Message-ID: <1483690609-15125-5-git-send-email-rasesh.mody@cavium.com> (raw)
In-Reply-To: <1483172217-30186-1-git-send-email-rasesh.mody@cavium.com>
From: Rasesh Mody <Rasesh.Mody@cavium.com>
Signed-off-by: Rasesh Mody <Rasesh.Mody@cavium.com>
---
drivers/net/qede/base/ecore_mcp.c | 2 +-
drivers/net/qede/qede_ethdev.c | 11 +++++------
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c
index bb13828..f634d98 100644
--- a/drivers/net/qede/base/ecore_mcp.c
+++ b/drivers/net/qede/base/ecore_mcp.c
@@ -931,7 +931,7 @@ static void ecore_mcp_send_protocol_stats(struct ecore_hwfn *p_hwfn,
hsi_param = DRV_MSG_CODE_STATS_TYPE_LAN;
break;
default:
- DP_NOTICE(p_hwfn, false, "Invalid protocol type %d\n", type);
+ DP_INFO(p_hwfn, "Invalid protocol type %d\n", type);
return;
}
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 6d90c46..c67fbb6 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -650,7 +650,7 @@ static void qede_vlan_offload_set(struct rte_eth_dev *eth_dev, int mask)
qede_vlan_filter_set(eth_dev, 0, 1);
} else {
if (qdev->configured_vlans > 1) { /* Excluding VLAN0 */
- DP_NOTICE(edev, false,
+ DP_ERR(edev,
" Please remove existing VLAN filters"
" before disabling VLAN filtering\n");
/* Signal app that VLAN filtering is still
@@ -684,7 +684,7 @@ static int qede_vlan_filter_set(struct rte_eth_dev *eth_dev,
if (on) {
if (qdev->configured_vlans == dev_info->num_vlan_filters) {
- DP_INFO(edev, "Reached max VLAN filter limit"
+ DP_ERR(edev, "Reached max VLAN filter limit"
" enabling accept_any_vlan\n");
qede_config_accept_any_vlan(qdev, true);
return 0;
@@ -849,14 +849,13 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
if (edev->num_hwfns > 1) {
if (eth_dev->data->nb_rx_queues < 2 ||
eth_dev->data->nb_tx_queues < 2) {
- DP_NOTICE(edev, false,
- "100G mode needs min. 2 RX/TX queues\n");
+ DP_ERR(edev, "100G mode needs min. 2 RX/TX queues\n");
return -EINVAL;
}
if ((eth_dev->data->nb_rx_queues % 2 != 0) ||
(eth_dev->data->nb_tx_queues % 2 != 0)) {
- DP_NOTICE(edev, false,
+ DP_ERR(edev,
"100G mode needs even no. of RX/TX queues\n");
return -EINVAL;
}
@@ -867,7 +866,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
eth_dev->data->scattered_rx = 1;
if (rxmode->enable_lro == 1) {
- DP_INFO(edev, "LRO is not supported\n");
+ DP_ERR(edev, "LRO is not supported\n");
return -EINVAL;
}
--
1.7.10.3
prev parent reply other threads:[~2017-01-06 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 8:16 [dpdk-dev] [PATCH 1/5] net/qede: fix scatter-gather issue Rasesh Mody
2016-12-31 8:16 ` [dpdk-dev] [PATCH 2/5] net/qede: fix minimum buffer size and scatter Rx check Rasesh Mody
2016-12-31 8:16 ` [dpdk-dev] [PATCH 3/5] net/qede: fix PF fastpath status block index Rasesh Mody
2016-12-31 8:16 ` [dpdk-dev] [PATCH 4/5] net/qede: fix per queue stats/xstats Rasesh Mody
2017-01-05 13:26 ` [dpdk-dev] [dpdk-stable] [PATCH 1/5] net/qede: fix scatter-gather issue Ferruh Yigit
2017-01-05 21:12 ` Harish Patil
2017-01-05 22:35 ` Mody, Rasesh
2017-01-06 8:16 ` [dpdk-dev] [PATCH v2 " Rasesh Mody
2017-01-06 13:31 ` Ferruh Yigit
2017-01-06 8:16 ` [dpdk-dev] [PATCH v2 2/5] net/qede: fix minimum buffer size and scatter Rx check Rasesh Mody
2017-01-06 8:16 ` [dpdk-dev] [PATCH v2 3/5] net/qede: fix PF fastpath status block index Rasesh Mody
2017-01-06 8:16 ` [dpdk-dev] [PATCH v2 4/5] net/qede: fix per queue stats/xstats Rasesh Mody
2017-01-06 8:16 ` Rasesh Mody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483690609-15125-5-git-send-email-rasesh.mody@cavium.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).