From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 99BAB2BB5 for ; Wed, 25 May 2016 19:22:41 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id n129so193450278wmn.1 for ; Wed, 25 May 2016 10:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=EbF6EJeAwcGc4tTNg5JU2avbTtpRjZEf38R5aRvzd6c=; b=NmPsi5eS7S8qfMUVc7FlCEJj3BDz5Kh16auBoc4tD8fTIrld0WEvz1mpNXsNHU5s9F KVaI8yLdCqG6ssTI00bJnZgln4rpfvCHSEpvfNUeZpF6to2VnuQeZLzCKrouvuXhTHLK AOj9ccyhhWHV1iJSnSgJJs48tbck6kE6GZvls+9Z3zhTSp6pBEFEPR+yupa8lfSC/DkM RDCXyd3pLBV2jwoXXkdAquAUhaTROGsdmfWplpwrYLdy6O2fyTdJDiROigaBq3N29RUM ayWokWA/byUO5wWieHR+MCkcT+9aL4JQqf2zym6PiB0T0O9fsKPLN0HFoOaItO0e2e+W D1qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=EbF6EJeAwcGc4tTNg5JU2avbTtpRjZEf38R5aRvzd6c=; b=CQw60vmOmKcR5qADcZGQ0YTLVTDul+0j8C1ykYxL1FyyctW/F2r/bLE++YQyMRiLqo b1un762OK8ScmcZsapWVplWr/jL6Z7C6sxd+cowaaYEQfKEnm7zBa0zj2ZjolvK7dELc upcPjCW1RD+BCPh+qK2+EFFzrTiDtysR5N6RgcSfHSfEo8vdmtKSezlCGhIA5ky1h1YB 7v8hlcibZIjb5tDGwdl7hy1ayA/sGdxjMLarW9xqCd9XmkeBrCnUHunqEePk8iHnhd+x r0B7s4s1a8d9nESyWaBORkbeyrElzRP7dSd0Yai3Ko7XaroKKCALUDbbFIIn4+Z9lSrI hg/w== X-Gm-Message-State: ALyK8tLS4V0rMD8Wx+MbojZiM9lU2+hDvy/RganJzOaP6HyXwUIkqAwNtp5CZDFXN+Q1DUrn X-Received: by 10.194.191.133 with SMTP id gy5mr5395511wjc.136.1464196961327; Wed, 25 May 2016 10:22:41 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u6sm25926876wmd.21.2016.05.25.10.22.40 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 10:22:40 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Panu Matilainen Date: Wed, 25 May 2016 19:22:39 +0200 Message-ID: <1484190.9fzbW2DJJe@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1464118912-19658-6-git-send-email-nhorman@tuxdriver.com> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1464118912-19658-1-git-send-email-nhorman@tuxdriver.com> <1464118912-19658-6-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 17:22:41 -0000 2016-05-24 15:41, Neil Horman: > Note that, in the case of dynamically linked applications, pmdinfo.py will scan > for implicitly linked PMDs by searching the specified binaries .dynamic section > for DT_NEEDED entries that contain the substring librte_pmd. I don't know any DPDK app dynamically linked with a PMD (with DT_NEEDED). However it is a good idea to handle this case. But relying on the name assumption "librte_pmd" is really weak. > + $(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/tools/pmdinfo.py, \ > + $(DESTDIR)$(bindir)/pmdinfo) I think we must prefix the tool name with dpdk. What about dpdk-objinfo or dpdk-pmdinfo? > +from elftools.elf.elffile import ELFFile > +from elftools.elf.dynamic import DynamicSection, DynamicSegment > +from elftools.elf.enums import ENUM_D_TAG > +from elftools.elf.segments import InterpSegment > +from elftools.elf.sections import SymbolTableSection Should it be possible to implement pmdinfogen with this Python library? I'll probably comment on the pmdinfo script details later. Just knowing you did a tool is enough to assert that it is a good step :) Thanks