DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] scripts: skip capitalization check for commit prefixes
@ 2017-01-13 13:02 Bruce Richardson
  2017-01-13 16:08 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Bruce Richardson @ 2017-01-13 13:02 UTC (permalink / raw)
  To: thomas.monjalon; +Cc: dev, Bruce Richardson

The prefix in the commit title must be a valid component name and is
checked in separate checks. For capitalization, just check the part after
the colon. This is already done for most capitalization checks, just make
the remainder consistent with this.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 scripts/check-git-log.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index f79f0a2..f6a35d2 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -113,10 +113,10 @@ bad=$(echo "$headlines" | grep --color=always \
 
 # check headline uppercase (Rx/Tx, VF, L2, MAC, Linux, ARM...)
 bad=$(echo "$headlines" | grep -E --color=always \
-	-e '\<(rx|tx|RX|TX)\>' \
-	-e '\<[pv]f\>' \
-	-e '\<[hsf]w\>' \
-	-e '\<l[234]\>' \
+	-e ':.*\<(rx|tx|RX|TX)\>' \
+	-e ':.*\<[pv]f\>' \
+	-e ':.*\<[hsf]w\>' \
+	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
 	-e ':.*\<arm\>' \
 	-e ':.*\<armv7\>' \
-- 
2.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] scripts: skip capitalization check for commit prefixes
  2017-01-13 13:02 [dpdk-dev] [PATCH] scripts: skip capitalization check for commit prefixes Bruce Richardson
@ 2017-01-13 16:08 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-01-13 16:08 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev

2017-01-13 13:02, Bruce Richardson:
> The prefix in the commit title must be a valid component name and is
> checked in separate checks. For capitalization, just check the part after
> the colon. This is already done for most capitalization checks, just make
> the remainder consistent with this.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-13 16:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-13 13:02 [dpdk-dev] [PATCH] scripts: skip capitalization check for commit prefixes Bruce Richardson
2017-01-13 16:08 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).