From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 7CA242A62 for ; Tue, 17 Jan 2017 15:55:00 +0100 (CET) Received: by mail-lf0-f49.google.com with SMTP id z134so106363960lff.3 for ; Tue, 17 Jan 2017 06:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=3Xdfe8YlmNK5c5Y3j1Nb0rz+43BZGX8/lUnzsd/MSGM=; b=PY9fb08cpxQhINuT56Nf/grfSKFkSGzGqbLH5JOalkPfZAEh6RNEj8zXCw4iC71bCi 8LMgTaamUrhelr1CQsPtAbwfdsw2pYup8ytjhSGNdXfHJi144sY0DE/zydiU80iR3dN9 734vh/VZJVW/0VQmTz0I+EpUAV2ZGxVU0FtSSAgHkCHOOfQeUGT25FARwkfo5Xhk+cdS g9DQ2bN43n1LWDgQVFmerG3LLQA6DDYHvZI+yNxv6PiycJLbLMq/W9fiS1aAWLIgDyd0 IWM06pZ/HuxQh49nAtF79pVujXHUZWqHJeZtfpy1HOdk2PjxoTt3NEYtNZjq8seTY94/ JBoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3Xdfe8YlmNK5c5Y3j1Nb0rz+43BZGX8/lUnzsd/MSGM=; b=jMl82+rqCfCIULoiMM7iP9fZbt4R83LlD4m1H8euLhhAQBOJqmV93sOO1XNiXokFvr ENED+Sheu7BqJk5DuEEYx4z2HEaDpA5HLVLiL2UXdhx6jGODFALNvRG5bwGSYXH5/66j OTauQBJLG1WOlV5JwRRJURM6imHO6MqDSqotALjpcUcgX8mRKE+xbi260YIkYrZ+7mtS LWspglcxT8YrFMAe2ZcmLFCH9DPHL14So9KLmW/ZZ4pmQpsiqHvOCrjtw38NHtvUiv8T V828Kw8YaN8p4QEY4ZDiSF4lq1/VqdrCSQNZm+CDKdtRQfMdu8edFhTPqTU9Xfd93AWs wTcA== X-Gm-Message-State: AIkVDXIbw4YAO4A4+1KOxQtSghsQbD/9YZAL6a5trrCSGli98WUOV0zBx2h8bdm+VDJL/Tlt X-Received: by 10.25.17.198 with SMTP id 67mr13992766lfr.39.1484664899850; Tue, 17 Jan 2017 06:54:59 -0800 (PST) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i1sm3571469ljb.15.2017.01.17.06.54.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Jan 2017 06:54:59 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Cc: Yuanhan Liu Date: Tue, 17 Jan 2017 15:54:32 +0100 Message-Id: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH] devtools: check stable tag in fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 14:55:00 -0000 The tag "Cc: stable@dpdk.org" must be set when the commit must be backported to a stable branch. It must be located just below the "Fixes:" tag (without blank line) and followed by a blank line, separated from SoB and review tags below. Signed-off-by: Thomas Monjalon --- devtools/check-git-log.sh | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index f6a35d2..9f1b435 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -170,9 +170,9 @@ bad=$(echo "$tags" | sed 's,^.,\t&,') [ -z "$bad" ] || printf "Wrong tag:\n$bad\n" -# check blank line after last Fixes: tag +# check blank line (or Cc: stable) after last Fixes: tag bad=$(echo "$bodylines" | - sed -n 'N;/\nFixes:/D;/\n$/D;/^Fixes:/P' | + sed -n 'N;/\nFixes:/D;/\nC[Cc]: stable@/D;/\n$/D;/^Fixes:/P' | sed 's,^.,\t&,') [ -z "$bad" ] || printf "Missing blank line after 'Fixes' tag:\n$bad\n" @@ -198,9 +198,15 @@ bad=$(for fixtag in $fixtags ; do done | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong 'Fixes' reference:\n$bad\n" -# check CC:stable for fixes +# check Cc: stable@dpdk.org for fixes bad=$(for fix in $stablefixes ; do - git log --format='%b' -1 $fix | grep -qi '^CC: *stable@dpdk.org' || + git log --format='%b' -1 $fix | grep -qi '^Cc: *stable@dpdk.org' || git log --format='\t%s' -1 $fix done) -[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n" +[ -z "$bad" ] || printf "Should Cc: stable@dpdk.org\n$bad\n" + +# check blank line after Cc: stable@dpdk.org +bad=$(echo "$bodylines" | + sed -n 'N;/\n$/D;/^C[Cc]: stable@dpdk.org/P' | + sed 's,^.,\t&,') +[ -z "$bad" ] || printf "Missing blank line after 'Cc: stable@':\n$bad\n" -- 2.7.0