DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Su <david.w.su@intel.com>
To: dev@dpdk.org
Cc: David Su <david.w.su@intel.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: keep interrupt throttling disabled
Date: Fri, 20 Jan 2017 15:10:25 -0800	[thread overview]
Message-ID: <1484953825-3203-1-git-send-email-david.w.su@intel.com> (raw)

The code being removed would enable time-based interrupt throttling for
the first MSI-X interrupt vector.  This would throttle link status
change interrupts for NICs bound to vfio_pci driver; but for
igb_uio driver, rx queue 0 interrupts would be throttled.  This resulted
in inconsistent latencies in a DPDK interrupt mode packet forwarding
application between the 2 drivers.

We'd like DPDK interrupt mode applications to be awaken by
inbound packet interrupts as soon as they are received regardless
of interrupt interval, interrupt throttling should be kept disabled.

Signed-off-by: David Su <david.w.su@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index bdf4e2b..fdfb7a6 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5815,8 +5815,6 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 	default:
 		break;
 	}
-	IXGBE_WRITE_REG(hw, IXGBE_EITR(IXGBE_MISC_VEC_ID),
-			IXGBE_MIN_INTER_INTERRUPT_INTERVAL_DEFAULT & 0xFFF);
 
 	/* set up to autoclear timer, and the vectors */
 	mask = IXGBE_EIMS_ENABLE_MASK;
-- 
1.7.0.4

             reply	other threads:[~2017-01-20 23:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 23:10 David Su [this message]
2017-03-30 14:28 ` Dai, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484953825-3203-1-git-send-email-david.w.su@intel.com \
    --to=david.w.su@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).