From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: zhao wei <wei.zhao1@gmail.com>
Subject: [dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple filter
Date: Mon, 23 Jan 2017 11:32:20 +0800 [thread overview]
Message-ID: <1485142340-49032-1-git-send-email-wei.zhao1@intel.com> (raw)
Add more check on the mask of src_addr, dst_addr and next_proto_id
in n-tuple filter rule pattern parser.If do not add such check,
it maybe cause error in pattern parser.
Signed-off-by: zhao wei <wei.zhao1@gmail.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 82aceed..8f78eee 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -331,7 +331,10 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
ipv4_mask->hdr.packet_id ||
ipv4_mask->hdr.fragment_offset ||
ipv4_mask->hdr.time_to_live ||
- ipv4_mask->hdr.hdr_checksum) {
+ ipv4_mask->hdr.hdr_checksum ||
+ !ipv4_mask->hdr.next_proto_id ||
+ !ipv4_mask->hdr.dst_addr ||
+ !ipv4_mask->hdr.src_addr ||) {
rte_flow_error_set(error,
EINVAL, RTE_FLOW_ERROR_TYPE_ITEM,
item, "Not supported by ntuple filter");
--
2.5.5
next reply other threads:[~2017-01-23 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 3:32 Wei Zhao [this message]
2017-01-23 12:22 ` Ferruh Yigit
2017-02-03 1:21 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485142340-49032-1-git-send-email-wei.zhao1@intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).