From: Yong Liu <yong.liu@intel.com>
To: dev@dpdk.org
Cc: Yong Liu <yong.liu@intel.com>
Subject: [dpdk-dev] [PATCH] examples: fix ip_reassembly not work with some NICs
Date: Mon, 23 Jan 2017 15:14:23 +0800 [thread overview]
Message-ID: <1485155663-4664-1-git-send-email-yong.liu@intel.com> (raw)
Some network device drivers like Fortville may not fill packet type by
default. Changed the method for detecting packet type from mbuf packet
type to ethernet header MAC type will make sure this example compatible
with all NICs.
Fixes: b84fb4cb88ff ("examples/ip_reassembly: overhaul")
Signed-off-by: Yong Liu <yong.liu@intel.com>
diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
index 50fe422..e1a1c3c 100644
--- a/examples/ip_reassembly/main.c
+++ b/examples/ip_reassembly/main.c
@@ -356,7 +356,7 @@ struct rte_lpm6_config lpm6_config = {
dst_port = portid;
/* if packet is IPv4 */
- if (RTE_ETH_IS_IPV4_HDR(m->packet_type)) {
+ if (eth_hdr->ether_type == rte_cpu_to_be_16(ETHER_TYPE_IPv4)) {
struct ipv4_hdr *ip_hdr;
uint32_t ip_dst;
@@ -395,8 +395,7 @@ struct rte_lpm6_config lpm6_config = {
dst_port = next_hop_ipv4;
}
- eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv4);
- } else if (RTE_ETH_IS_IPV6_HDR(m->packet_type)) {
+ } else if (eth_hdr->ether_type == rte_cpu_to_be_16(ETHER_TYPE_IPv6)){
/* if packet is IPv6 */
struct ipv6_extension_fragment *frag_hdr;
struct ipv6_hdr *ip_hdr;
@@ -431,8 +430,6 @@ struct rte_lpm6_config lpm6_config = {
(enabled_port_mask & 1 << next_hop_ipv6) != 0) {
dst_port = next_hop_ipv6;
}
-
- eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv6);
}
/* if packet wasn't IPv4 or IPv6, it's forwarded to the port it came from */
--
1.9.3
reply other threads:[~2017-01-23 7:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485155663-4664-1-git-send-email-yong.liu@intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).