From: Beilei Xing <beilei.xing@intel.com>
To: jingjing.wu@intel.com
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
Subject: [dpdk-dev] [PATCH] net/i40e: fix parsing tunnel filter issue
Date: Tue, 24 Jan 2017 10:44:27 +0800 [thread overview]
Message-ID: <1485225867-116610-1-git-send-email-beilei.xing@intel.com> (raw)
VNI of VXLAN is parsed wrongly. The root cause is that
array vni in item VXLAN also uses network byte ordering.
Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/i40e_flow.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 76bb332..51b3223 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -1196,6 +1196,20 @@ i40e_check_tenant_id_mask(const uint8_t *mask)
return is_masked;
}
+static uint32_t
+i40e_flow_set_tenant_id(const uint8_t *vni)
+{
+ uint32_t tenant_id;
+
+#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
+ tenant_id = (vni[0] << 16) | (vni[1] << 8) | vni[2];
+#else
+ tenant_id = vni[0] | (vni[1] << 8) | (vni[2] << 16);
+#endif
+
+ return tenant_id;
+}
+
/* 1. Last in item should be NULL as range is not supported.
* 2. Supported filter types: IMAC_IVLAN_TENID, IMAC_IVLAN,
* IMAC_TENID, OMAC_TENID_IMAC and IMAC.
@@ -1364,8 +1378,8 @@ i40e_flow_parse_vxlan_pattern(const struct rte_flow_item *pattern,
& I40E_TCI_MASK;
if (vxlan_spec && vxlan_mask && !is_vni_masked) {
/* If there's vxlan */
- rte_memcpy(&filter->tenant_id, vxlan_spec->vni,
- RTE_DIM(vxlan_spec->vni));
+ filter->tenant_id =
+ i40e_flow_set_tenant_id(vxlan_spec->vni);
if (!o_eth_spec && !o_eth_mask &&
i_eth_spec && i_eth_mask)
filter->filter_type =
@@ -1402,8 +1416,8 @@ i40e_flow_parse_vxlan_pattern(const struct rte_flow_item *pattern,
/* If there's no inner vlan */
if (vxlan_spec && vxlan_mask && !is_vni_masked) {
/* If there's vxlan */
- rte_memcpy(&filter->tenant_id, vxlan_spec->vni,
- RTE_DIM(vxlan_spec->vni));
+ filter->tenant_id =
+ i40e_flow_set_tenant_id(vxlan_spec->vni);
if (!o_eth_spec && !o_eth_mask &&
i_eth_spec && i_eth_mask)
filter->filter_type =
--
2.5.5
next reply other threads:[~2017-01-24 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 2:44 Beilei Xing [this message]
2017-01-24 2:58 ` Lu, Wenzhuo
2017-01-24 15:17 ` Ferruh Yigit
2017-02-06 1:38 ` Xing, Beilei
2017-02-06 5:29 ` [dpdk-dev] [PATCH v2] " Beilei Xing
2017-02-07 14:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485225867-116610-1-git-send-email-beilei.xing@intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).