* [dpdk-dev] [PATCH] eal: fix wrong log at startup
@ 2017-01-24 16:21 Olivier Matz
2017-01-29 21:57 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Olivier Matz @ 2017-01-24 16:21 UTC (permalink / raw)
To: dev, david.marchand
The log "Debug logs available - lower performance" should
now only be displayed when dataplane debug logs are enabled.
The issue occurs only if the default log level (CONFIG_RTE_LOG_LEVEL) is
set to DEBUG in the configuration, which is not the case by default.
Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_eal/common/eal_common_log.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index e45d326..2197558 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -176,7 +176,8 @@ eal_log_set_default(FILE *default_log)
{
default_log_stream = default_log;
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
- RTE_LOG(NOTICE, EAL, "Debug logs available - lower performance\n");
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+ RTE_LOG(NOTICE, EAL,
+ "Debug dataplane logs available - lower performance\n");
#endif
}
--
2.8.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix wrong log at startup
2017-01-24 16:21 [dpdk-dev] [PATCH] eal: fix wrong log at startup Olivier Matz
@ 2017-01-29 21:57 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-01-29 21:57 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, david.marchand
2017-01-24 17:21, Olivier Matz:
> The log "Debug logs available - lower performance" should
> now only be displayed when dataplane debug logs are enabled.
>
> The issue occurs only if the default log level (CONFIG_RTE_LOG_LEVEL) is
> set to DEBUG in the configuration, which is not the case by default.
>
> Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-29 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 16:21 [dpdk-dev] [PATCH] eal: fix wrong log at startup Olivier Matz
2017-01-29 21:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).