From: Shahaf Shuler <shahafs@mellanox.com>
To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix link status query
Date: Wed, 25 Jan 2017 14:42:58 +0200 [thread overview]
Message-ID: <1485348178-43771-1-git-send-email-shahafs@mellanox.com> (raw)
Trying to query the link status through new kernel ioctl API
ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
The bug was fixed on version 4.9
this patch uses the legacy ioctl API for lower kernels.
Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
CC: stable@dpdk.org
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
while the ETHTOOL_GLINKSETTINGS API was introduced on kernel v4.6 [1]
the bug was fixed only on kernel v4.9 [2]
[1] https://github.com/torvalds/linux/commit/3f1ac7a700d039c61d8d8b99f28d605d489a60cf
[2] https://github.com/torvalds/linux/commit/8006f6bf5e39f11c697f48df20382b81d2f2f8b8
---
drivers/net/mlx5/mlx5_ethdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 8efdff7..e77238f 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -46,6 +46,7 @@
#include <netinet/in.h>
#include <linux/ethtool.h>
#include <linux/sockios.h>
+#include <linux/version.h>
#include <fcntl.h>
/* DPDK headers don't like -pedantic. */
@@ -697,7 +698,7 @@ struct priv *
/**
* Retrieve physical link information (unlocked version using new ioctl from
- * Linux 4.5).
+ * Linux 4.9).
*
* @param dev
* Pointer to Ethernet device structure.
@@ -707,7 +708,7 @@ struct priv *
static int
mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete)
{
-#ifdef ETHTOOL_GLINKSETTINGS
+#if KERNEL_VERSION(4, 9, 0) <= LINUX_VERSION_CODE
struct priv *priv = mlx5_get_priv(dev);
struct ethtool_link_settings edata = {
.cmd = ETHTOOL_GLINKSETTINGS,
--
1.8.3.1
next reply other threads:[~2017-01-25 12:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 12:42 Shahaf Shuler [this message]
2017-01-30 15:25 ` Nélio Laranjeiro
2017-01-31 11:45 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2017-01-31 15:42 ` Nélio Laranjeiro
2017-02-01 18:31 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-02-02 8:20 ` Nélio Laranjeiro
2017-02-02 10:18 ` Ferruh Yigit
2017-01-31 16:17 ` Ferruh Yigit
2017-02-01 6:53 ` Shahaf Shuler
2017-02-01 9:07 ` Adrien Mazarguil
2017-02-01 11:13 ` Ferruh Yigit
2017-02-01 12:57 ` Adrien Mazarguil
2017-02-01 18:11 ` Ferruh Yigit
2017-02-02 8:45 ` Adrien Mazarguil
2017-02-02 10:15 ` Ferruh Yigit
2017-02-02 10:37 ` Adrien Mazarguil
2017-02-02 10:43 ` Ferruh Yigit
2017-02-09 12:29 ` [dpdk-dev] [PATCH v3] " Shahaf Shuler
2017-02-09 14:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485348178-43771-1-git-send-email-shahafs@mellanox.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).