From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id D72D45952 for ; Thu, 12 Mar 2015 08:37:03 +0100 (CET) Received: by wesw55 with SMTP id w55so14370600wes.3 for ; Thu, 12 Mar 2015 00:37:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xL7PxHPrTT5L4DJ/W62m+gabRT05+4PrkwAGz/vFlbU=; b=Isq7X3RlM1o3Fya07O3Ho++4xxcTz49y0rrnhrk/OsGpU3Q0s1yFTJYqErUdc0HGj3 O7YyOyI6cDMAPeWerhL/I8bAndm/dmr1ZKcWEhF6wua+do4z6gtHPJhkKazARmazumR3 b3cEUy76HEYOH2ztX23TzmvqwvqZFPQokueId6d50KR5svZ1+xt5OZiQpdsXvmqk4TP0 BtpUPQZPobzLxu070qD+ih+onh7kE2SeOufpDpIUMqdyj4aNlqeOR8XZ0ZvehRiZ1syH 3nSYJ7zbryPReH/wGfte1gjNJ6sSO12G5VgdYTTOXfh9XYI8i5G/mDefdgQ9iGlUDV8g h7ZA== X-Gm-Message-State: ALoCoQll/0HMJNMu/ykBDDoZON9yvdMkunrf8GJtRj5nOlK158+7rtoSCviX0fTZFNn+G4vxA9an X-Received: by 10.194.120.132 with SMTP id lc4mr86491148wjb.92.1426145823704; Thu, 12 Mar 2015 00:37:03 -0700 (PDT) Received: from xps13.localnet ([92.245.149.52]) by mx.google.com with ESMTPSA id gi9sm11821701wib.21.2015.03.12.00.37.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2015 00:37:01 -0700 (PDT) From: Thomas Monjalon To: David Marchand Date: Thu, 12 Mar 2015 08:36:22 +0100 Message-ID: <1485430.lunJJ757N3@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1426094723-18766-1-git-send-email-david.marchand@6wind.com> References: <1426094723-18766-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix tailq init for uio/vfio resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 07:37:04 -0000 2015-03-11 18:25, David Marchand: > Commit a2348166ea18 ("tailq: move to dynamic tailq") introduced a bug in > uio/vfio resources list init. > > These resources list were pointed at through a pointer initialised only once but > too early in the eal init (before tailqs init). > > Fix this by "resolving" this pointer when used (which is well after tailqs > init). > > Fixes: a2348166ea18 ("tailq: move to dynamic tailq") > Reported-by: Marvin Liu > Reported-by: Tetsuya Mukawa > Signed-off-by: David Marchand > --- > > This patch is an alternative to the patch proposed by Marvin. > It has been tested only on Linux and with uio driver. Applied, thanks