* [dpdk-dev] [PATCH] app/testpmd: fix memory leak @ 2017-01-27 13:15 Pablo de Lara 2017-01-27 14:54 ` [dpdk-dev] [PATCH v2] " Pablo de Lara 0 siblings, 1 reply; 4+ messages in thread From: Pablo de Lara @ 2017-01-27 13:15 UTC (permalink / raw) To: adrien.mazarguil, jingjing.wu; +Cc: dev, Pablo de Lara Free memory when port flow entry creation fails. Coverity issue: 139600 Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- app/test-pmd/config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 5834498..5823100 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -954,6 +954,8 @@ port_flow_new(const struct rte_flow_attr *attr, goto store; } notsup: + if (pf) + free(pf); rte_errno = err; return NULL; } -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak 2017-01-27 13:15 [dpdk-dev] [PATCH] app/testpmd: fix memory leak Pablo de Lara @ 2017-01-27 14:54 ` Pablo de Lara 2017-01-30 9:33 ` Adrien Mazarguil 0 siblings, 1 reply; 4+ messages in thread From: Pablo de Lara @ 2017-01-27 14:54 UTC (permalink / raw) To: adrien.mazarguil, jingjing.wu; +Cc: dev, Pablo de Lara Free memory when port flow entry creation fails. Coverity issue: 139600 Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- Changes in v2: - Removed unnecessary conditional app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 5834498..467932f 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -954,6 +954,7 @@ port_flow_new(const struct rte_flow_attr *attr, goto store; } notsup: + free(pf); rte_errno = err; return NULL; } -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak 2017-01-27 14:54 ` [dpdk-dev] [PATCH v2] " Pablo de Lara @ 2017-01-30 9:33 ` Adrien Mazarguil 2017-01-30 12:26 ` De Lara Guarch, Pablo 0 siblings, 1 reply; 4+ messages in thread From: Adrien Mazarguil @ 2017-01-30 9:33 UTC (permalink / raw) To: Pablo de Lara; +Cc: jingjing.wu, dev Hi Pablo, On Fri, Jan 27, 2017 at 02:54:58PM +0000, Pablo de Lara wrote: > Free memory when port flow entry creation fails. > > Coverity issue: 139600 > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- > Changes in v2: > > - Removed unnecessary conditional > > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 5834498..467932f 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -954,6 +954,7 @@ port_flow_new(const struct rte_flow_attr *attr, > goto store; > } > notsup: > + free(pf); > rte_errno = err; > return NULL; > } > -- > 2.7.4 > I think this is a false positive, which is why I did not address it during the last round of Coverity issues. As a two-pass function, errors are checked during the first pass, when pf is not allocated yet. During the second pass, intermediate functions are not supposed to return a different result and "notsup" cannot occur. I think assert()/rte_assert() would make more sense and should fool Coverity into understanding the expected behavior. The commit log should reflect that we are addressing a false positive since there is no problem with the code logic (of course unless I missed anything obvious). Thanks. -- Adrien Mazarguil 6WIND ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak 2017-01-30 9:33 ` Adrien Mazarguil @ 2017-01-30 12:26 ` De Lara Guarch, Pablo 0 siblings, 0 replies; 4+ messages in thread From: De Lara Guarch, Pablo @ 2017-01-30 12:26 UTC (permalink / raw) To: Adrien Mazarguil; +Cc: Wu, Jingjing, dev Hi Adrien, > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Monday, January 30, 2017 9:33 AM > To: De Lara Guarch, Pablo > Cc: Wu, Jingjing; dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd: fix memory leak > > Hi Pablo, > > On Fri, Jan 27, 2017 at 02:54:58PM +0000, Pablo de Lara wrote: > > Free memory when port flow entry creation fails. > > > > Coverity issue: 139600 > > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow > API") > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > > --- > > Changes in v2: > > > > - Removed unnecessary conditional > > > > app/test-pmd/config.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > > index 5834498..467932f 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -954,6 +954,7 @@ port_flow_new(const struct rte_flow_attr *attr, > > goto store; > > } > > notsup: > > + free(pf); > > rte_errno = err; > > return NULL; > > } > > -- > > 2.7.4 > > > > I think this is a false positive, which is why I did not address it during > the last round of Coverity issues. > > As a two-pass function, errors are checked during the first pass, when pf is > not allocated yet. During the second pass, intermediate functions are not > supposed to return a different result and "notsup" cannot occur. > > I think assert()/rte_assert() would make more sense and should fool > Coverity > into understanding the expected behavior. > > The commit log should reflect that we are addressing a false positive since > there is no problem with the code logic (of course unless I missed anything > obvious). Then, I would just ignore the coverity issue, changing the status to intentional. Thanks, Pablo > > Thanks. > > -- > Adrien Mazarguil > 6WIND ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-30 12:26 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-01-27 13:15 [dpdk-dev] [PATCH] app/testpmd: fix memory leak Pablo de Lara 2017-01-27 14:54 ` [dpdk-dev] [PATCH v2] " Pablo de Lara 2017-01-30 9:33 ` Adrien Mazarguil 2017-01-30 12:26 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).