DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: adrien.mazarguil@6wind.com, jingjing.wu@intel.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak
Date: Fri, 27 Jan 2017 14:54:58 +0000	[thread overview]
Message-ID: <1485528898-53283-1-git-send-email-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <1485522948-210951-1-git-send-email-pablo.de.lara.guarch@intel.com>

Free memory when port flow entry creation fails.

Coverity issue: 139600
Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:

- Removed unnecessary conditional

 app/test-pmd/config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 5834498..467932f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -954,6 +954,7 @@ port_flow_new(const struct rte_flow_attr *attr,
 		goto store;
 	}
 notsup:
+	free(pf);
 	rte_errno = err;
 	return NULL;
 }
-- 
2.7.4

  reply	other threads:[~2017-01-27 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 13:15 [dpdk-dev] [PATCH] " Pablo de Lara
2017-01-27 14:54 ` Pablo de Lara [this message]
2017-01-30  9:33   ` [dpdk-dev] [PATCH v2] " Adrien Mazarguil
2017-01-30 12:26     ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485528898-53283-1-git-send-email-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).