From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 06/25] eal-common: introduce a way to query cpu support
Date: Fri, 27 Jan 2017 09:56:44 -0500 [thread overview]
Message-ID: <1485529023-5486-7-git-send-email-aconole@redhat.com> (raw)
In-Reply-To: <1485529023-5486-1-git-send-email-aconole@redhat.com>
This adds a new API to check for the eal cpu versions.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
lib/librte_eal/common/eal_common_cpuflags.c | 13 +++++++++++--
lib/librte_eal/common/include/generic/rte_cpuflags.h | 9 +++++++++
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
index b5f76f7..2c2127b 100644
--- a/lib/librte_eal/common/eal_common_cpuflags.c
+++ b/lib/librte_eal/common/eal_common_cpuflags.c
@@ -43,6 +43,13 @@
void
rte_cpu_check_supported(void)
{
+ if (!rte_cpu_is_supported())
+ exit(1);
+}
+
+bool
+rte_cpu_is_supported(void)
+{
/* This is generated at compile-time by the build system */
static const enum rte_cpu_flag_t compile_time_flags[] = {
RTE_COMPILE_TIME_CPUFLAGS
@@ -57,14 +64,16 @@ rte_cpu_check_supported(void)
fprintf(stderr,
"ERROR: CPU feature flag lookup failed with error %d\n",
ret);
- exit(1);
+ return false;
}
if (!ret) {
fprintf(stderr,
"ERROR: This system does not support \"%s\".\n"
"Please check that RTE_MACHINE is set correctly.\n",
rte_cpu_get_flag_name(compile_time_flags[i]));
- exit(1);
+ return false;
}
}
+
+ return true;
}
diff --git a/lib/librte_eal/common/include/generic/rte_cpuflags.h b/lib/librte_eal/common/include/generic/rte_cpuflags.h
index 71321f3..e4342ad 100644
--- a/lib/librte_eal/common/include/generic/rte_cpuflags.h
+++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h
@@ -40,6 +40,7 @@
*/
#include <errno.h>
+#include <stdbool.h>
/**
* Enumeration of all CPU features supported
@@ -82,4 +83,12 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
void
rte_cpu_check_supported(void);
+/**
+ * This function checks that the currently used CPU supports the CPU features
+ * that were specified at compile time. It is called automatically within the
+ * EAL, so does not need to be used by applications. This version returns a
+ * result so that decisions may be made (for instance, graceful shutdowns).
+ */
+bool
+rte_cpu_is_supported(void);
#endif /* _RTE_CPUFLAGS_H_ */
--
2.7.4
next prev parent reply other threads:[~2017-01-27 14:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 14:56 [dpdk-dev] [PATCH 00/24] linux/eal: Remove most causes of panic on init Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 01/25] eal: CPU init will no longer panic Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 02/25] eal: return error instead of panic for cpu init Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 03/25] eal: No panic on hugepages info init Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 04/25] eal: do not panic on failed hugepage query Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 05/25] eal: failure to parse args returns error Aaron Conole
2017-01-27 14:56 ` Aaron Conole [this message]
2017-01-27 14:56 ` [dpdk-dev] [PATCH 07/25] eal: Signal error when CPU isn't supported Aaron Conole
2017-01-27 16:27 ` Stephen Hemminger
2017-01-30 16:50 ` Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 08/25] eal: do not panic on memzone initialization fails Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 09/25] eal: set errno when exiting for already called Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 10/25] eal: Do not panic on log failures Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 11/25] eal: Do not panic on pci-probe Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 12/25] eal: do not panic on vfio failure Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 13/25] eal: do not panic on memory init Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 14/25] eal: do not panic on tailq init Aaron Conole
2017-01-27 16:30 ` Stephen Hemminger
2017-01-30 16:51 ` Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init Aaron Conole
2017-01-27 16:31 ` Stephen Hemminger
2017-01-27 16:42 ` Bruce Richardson
2017-01-30 16:52 ` Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 16/25] eal: convert timer_init not to call panic Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 17/25] eal: change the private pipe call to reflect errno Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 18/25] eal: Do not panic on interrupt thread init Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 19/25] eal: do not error if plugins fail to init Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 20/25] eal_pci: Continue probing even on failures Aaron Conole
2017-01-27 14:56 ` [dpdk-dev] [PATCH 21/25] eal: do not panic on failed PCI probe Aaron Conole
2017-01-27 14:57 ` [dpdk-dev] [PATCH 22/25] eal_common_dev: continue initializing vdevs Aaron Conole
2017-01-27 14:57 ` [dpdk-dev] [PATCH 23/25] eal: do not panic (or abort) if vdev init fails Aaron Conole
2017-01-27 14:57 ` [dpdk-dev] [PATCH 24/25] eal: do not panic when bus probe fails Aaron Conole
2017-01-27 14:57 ` [dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes Aaron Conole
2017-01-27 16:33 ` Stephen Hemminger
2017-01-27 16:47 ` Bruce Richardson
2017-01-27 17:37 ` Stephen Hemminger
2017-01-30 18:38 ` Aaron Conole
2017-01-30 20:19 ` Thomas Monjalon
2017-02-01 10:54 ` Adrien Mazarguil
2017-02-01 12:06 ` Jan Blunck
2017-02-01 14:18 ` Bruce Richardson
2017-01-31 9:33 ` Bruce Richardson
2017-01-31 16:56 ` Stephen Hemminger
2017-01-27 15:48 ` [dpdk-dev] [PATCH 00/24] linux/eal: Remove most causes of panic on init Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485529023-5486-7-git-send-email-aconole@redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).