DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jingjing Wu <jingjing.wu@intel.com>
To: dev@dpdk.org
Cc: jingjing.wu@intel.com, olivier.matz@6wind.com
Subject: [dpdk-dev] [PATCH v2 1/5] mbuf: fix bitmask of Tx offload flags
Date: Sat,  4 Feb 2017 11:36:11 +0800	[thread overview]
Message-ID: <1486179375-133509-2-git-send-email-jingjing.wu@intel.com> (raw)
In-Reply-To: <1486179375-133509-1-git-send-email-jingjing.wu@intel.com>

Some Tx offload flags are missed in bitmask of all supported packet
Tx offload features flags.
This patch fixes it by redefining PKT_TX_OFFLOAD_MASK.
PKT_RX_OFFLOAD_MASK is also defined in this patch.

CC: olivier.matz@6wind.com
Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 lib/librte_mbuf/rte_mbuf.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 0d01167..018a604 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -177,10 +177,11 @@ extern "C" {
  */
 #define PKT_RX_LRO           (1ULL << 16)
 
-/* add new RX flags here */
-
-/* add new TX flags here */
+/* add new RX flags here, and update __PKT_RX_NEXT */
+#define __PKT_RX_NEXT        (1ULL << 17)
 
+/* add new TX flags here, and update __PKT_TX_NEXT */
+#define __PKT_TX_NEXT        (1ULL << 43)
 /**
  * Offload the MACsec. This flag must be set by the application to enable
  * this offload feature for a packet to be transmitted.
@@ -283,6 +284,12 @@ extern "C" {
 #define PKT_TX_OUTER_IPV4   (1ULL << 59)
 
 /**
+ * Bitmask of all supported packet Rx offload features flags,
+ * which can be set for packet.
+ **/
+#define PKT_RX_OFFLOAD_MASK (__PKT_RX_NEXT - 1)
+
+/**
  * Packet outer header is IPv6. This flag must be set when using any
  * outer offload feature (L4 checksum) to tell the NIC that the outer
  * header of the tunneled packet is an IPv6 packet.
@@ -293,14 +300,7 @@ extern "C" {
  * Bitmask of all supported packet Tx offload features flags,
  * which can be set for packet.
  */
-#define PKT_TX_OFFLOAD_MASK (    \
-		PKT_TX_IP_CKSUM |        \
-		PKT_TX_L4_MASK |         \
-		PKT_TX_OUTER_IP_CKSUM |  \
-		PKT_TX_TCP_SEG |         \
-		PKT_TX_QINQ_PKT |        \
-		PKT_TX_VLAN_PKT |        \
-		PKT_TX_TUNNEL_MASK)
+#define PKT_TX_OFFLOAD_MASK ((~(__PKT_TX_NEXT - 1)) & 0x1fffffffffffffff)
 
 #define __RESERVED           (1ULL << 61) /**< reserved for future mbuf use */
 
-- 
2.4.11

  reply	other threads:[~2017-02-04  3:38 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 11:50 [dpdk-dev] [PATCH 1/2] " Jingjing Wu
2017-01-24 11:50 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix bitmask of supported Tx flags Jingjing Wu
2017-01-26 14:19 ` [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags Ferruh Yigit
2017-02-04  3:36 ` [dpdk-dev] [PATCH v2 0/5] fix bitmask of supported Tx flags Jingjing Wu
2017-02-04  3:36   ` Jingjing Wu [this message]
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 2/5] net/i40e: " Jingjing Wu
2017-02-05 10:28     ` Ferruh Yigit
2017-02-06  3:02       ` Wu, Jingjing
2017-02-06 10:28         ` Olivier Matz
2017-02-07  2:30           ` Wu, Jingjing
2017-02-06 10:26     ` Olivier Matz
2017-02-07  2:30       ` Wu, Jingjing
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 3/5] net/ixgbe: " Jingjing Wu
2017-02-05 11:59     ` Ananyev, Konstantin
2017-02-05 12:10       ` Ananyev, Konstantin
2017-02-06  8:53         ` Wu, Jingjing
2017-02-06 12:11           ` Ananyev, Konstantin
2017-02-07  2:29             ` Wu, Jingjing
2017-02-08  0:34               ` Ananyev, Konstantin
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 4/5] net/e1000: " Jingjing Wu
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 5/5] net/fm10k: " Jingjing Wu
2017-02-07  3:22   ` [dpdk-dev] [PATCH v3 0/4] " Jingjing Wu
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 1/4] net/i40e: " Jingjing Wu
2017-02-07 13:48       ` Ferruh Yigit
2017-02-07 15:45         ` Wu, Jingjing
2017-02-07 16:01           ` Ferruh Yigit
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 2/4] net/ixgbe: " Jingjing Wu
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 3/4] net/e1000: " Jingjing Wu
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 4/4] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-08  5:05     ` [dpdk-dev] [PATCH v4 0/4] fix bitmask of supported Tx flags Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 1/4] net/i40e: " Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 2/4] net/ixgbe: " Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 3/4] net/e1000: " Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 4/4] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-08 16:27         ` Olivier MATZ
2017-02-08 16:32       ` [dpdk-dev] [PATCH v4 0/4] fix bitmask of supported Tx flags Ferruh Yigit
2017-02-09  1:13         ` Wu, Jingjing
2017-02-08 16:46       ` Ananyev, Konstantin
2017-02-09 14:37         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486179375-133509-2-git-send-email-jingjing.wu@intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).