From: Wei Dai <wei.dai@intel.com>
To: dev@dpdk.org
Cc: helin.zhang@intel.com, konstantin.ananyev@intel.com,
Wei Dai <wei.dai@intel.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: output details on failure to configure filter
Date: Sat, 4 Feb 2017 16:28:20 +0800 [thread overview]
Message-ID: <1486196900-33658-1-git-send-email-wei.dai@intel.com> (raw)
Add more details when the filter mode can't be successfully configured.
These details tell user what filter configuration is right.
Reported-by: Yulong Pei <yulong.pei@intel.com>
Signed-off-by: Wei Dai <wei.dai@intel.com>
---
drivers/net/ixgbe/ixgbe_fdir.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 3b9d60c..a23581f 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -628,16 +628,25 @@ ixgbe_fdir_configure(struct rte_eth_dev *dev)
hw->mac.type != ixgbe_mac_X540 &&
hw->mac.type != ixgbe_mac_X550 &&
hw->mac.type != ixgbe_mac_X550EM_x &&
- hw->mac.type != ixgbe_mac_X550EM_a)
+ hw->mac.type != ixgbe_mac_X550EM_a) {
+ PMD_INIT_LOG(err, "Only when ixgbe MAC type is 82599EB or X540 or X550 "
+ "or X550EM_x or X550EM_a, a filter mode can be supported. "
+ "Current MAC type = %d", (int)(hw->mac.type));
return -ENOSYS;
+ }
/* x550 supports mac-vlan and tunnel mode but other NICs not */
if (hw->mac.type != ixgbe_mac_X550 &&
hw->mac.type != ixgbe_mac_X550EM_x &&
hw->mac.type != ixgbe_mac_X550EM_a &&
mode != RTE_FDIR_MODE_SIGNATURE &&
- mode != RTE_FDIR_MODE_PERFECT)
+ mode != RTE_FDIR_MODE_PERFECT) {
+ PMD_INIT_LOG(err, "If ixgbe MAC type is not X550 or X550EM_x or "
+ "X550EM_a, the filter mode must be signature or perfect, other mode "
+ "is not supported ! Current MAC type = %d filter mode = %d",
+ (int)(hw->mac.type), (int)mode);
return -ENOSYS;
+ }
err = configure_fdir_flags(&dev->data->dev_conf.fdir_conf, &fdirctrl);
if (err)
--
2.7.4
next reply other threads:[~2017-02-04 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 8:28 Wei Dai [this message]
2017-02-04 8:37 Wei Dai
2017-02-04 21:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486196900-33658-1-git-send-email-wei.dai@intel.com \
--to=wei.dai@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).