[dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

[dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

[Kuba Kozak]

Added total_ops value validation in parse_total_ops() function.

Coverity issue: 141070

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
---
 app/test-crypto-perf/cperf_options_parsing.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index 3b7342d..3a8b898 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -128,7 +128,13 @@ struct name_id_map {
 	int ret = parse_uint32_t(&opts->total_ops, arg);
 
 	if (ret)
-		RTE_LOG(ERR, USER1, "failed to parse total operations count");
+		RTE_LOG(ERR, USER1, "failed to parse total operations count\n");
+
+	if (opts->total_ops == 0) {
+		RTE_LOG(ERR, USER1,
+				"invalid total operations count number specified\n");
+		return -1;
+	}
 
 	return ret;
 }
-- 
1.9.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> Sent: Tuesday, February 07, 2017 12:20 PM
> To: Doherty, Declan
> Cc: dev@dpdk.org; Kozak, KubaX
> Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation
> 
> Added total_ops value validation in parse_total_ops() function.
> 
> Coverity issue: 141070
> 
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
> 
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Thursday, February 09, 2017 11:18 PM
> To: Kozak, KubaX; Doherty, Declan
> Cc: dev@dpdk.org; Kozak, KubaX
> Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value
> validation
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> > Sent: Tuesday, February 07, 2017 12:20 PM
> > To: Doherty, Declan
> > Cc: dev@dpdk.org; Kozak, KubaX
> > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value
> validation
> >
> > Added total_ops value validation in parse_total_ops() function.
> >
> > Coverity issue: 141070
> >
> > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> > application")
> >
> > Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo