From: Qiming Yang <qiming.yang@intel.com>
To: dev@dpdk.org
Cc: jingjing.wu@intel.com, cunming.liang@intel.com,
Qiming Yang <qiming.yang@intel.com>
Subject: [dpdk-dev] [PATCH] net/i40e: fix link update delay
Date: Wed, 8 Feb 2017 17:14:24 +0800 [thread overview]
Message-ID: <1486545264-23218-1-git-send-email-qiming.yang@intel.com> (raw)
This patch fixed the redundant delay in function link update. There is
no need to call rte_delay_ms and hold CPU for 100ms when link status is up.
Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 4492bcc..75d092f 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2220,11 +2220,11 @@ i40e_dev_link_update(struct rte_eth_dev *dev,
}
link.link_status = link_status.link_info & I40E_AQ_LINK_UP;
- if (!wait_to_complete)
+ if (!wait_to_complete || link.link_status)
break;
rte_delay_ms(CHECK_INTERVAL);
- } while (!link.link_status && rep_cnt--);
+ } while (--rep_cnt);
if (!link.link_status)
goto out;
--
2.7.4
next reply other threads:[~2017-02-08 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 9:14 Qiming Yang [this message]
2017-02-08 15:30 ` Ferruh Yigit
2017-02-08 15:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486545264-23218-1-git-send-email-qiming.yang@intel.com \
--to=qiming.yang@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).