From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CA119DE0 for ; Wed, 8 Feb 2017 10:20:47 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 08 Feb 2017 01:20:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="931444450" Received: from dpdk7.bj.intel.com ([172.16.182.76]) by orsmga003.jf.intel.com with ESMTP; 08 Feb 2017 01:20:45 -0800 From: Qiming Yang To: dev@dpdk.org Cc: jingjing.wu@intel.com, cunming.liang@intel.com, Qiming Yang Date: Wed, 8 Feb 2017 17:14:24 +0800 Message-Id: <1486545264-23218-1-git-send-email-qiming.yang@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] net/i40e: fix link update delay X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 09:20:48 -0000 This patch fixed the redundant delay in function link update. There is no need to call rte_delay_ms and hold CPU for 100ms when link status is up. Fixes: 263333bbb7a9 ("i40e: fix link status timeout") Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4492bcc..75d092f 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2220,11 +2220,11 @@ i40e_dev_link_update(struct rte_eth_dev *dev, } link.link_status = link_status.link_info & I40E_AQ_LINK_UP; - if (!wait_to_complete) + if (!wait_to_complete || link.link_status) break; rte_delay_ms(CHECK_INTERVAL); - } while (!link.link_status && rep_cnt--); + } while (--rep_cnt); if (!link.link_status) goto out; -- 2.7.4