From: Jacek Piasecki <jacekx.piasecki@intel.com>
To: declan.doherty@intel.com
Cc: dev@dpdk.org, Jacek Piasecki <jacekx.piasecki@intel.com>
Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix big paremeter passed by value
Date: Wed, 8 Feb 2017 17:04:40 +0100 [thread overview]
Message-ID: <1486569881-16220-1-git-send-email-jacekx.piasecki@intel.com> (raw)
Structure opts and structure test_vec are now passed by pointer to
the cperf_check_test_vector.
Coverity issue: 141072
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
application")
Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
---
app/test-crypto-perf/main.c | 98 ++++++++++++++++++++++-----------------------
1 file changed, 49 insertions(+), 49 deletions(-)
diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 6c128d8..634ea5f 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -162,94 +162,94 @@
}
static int
-cperf_check_test_vector(struct cperf_options opts,
- struct cperf_test_vector test_vec)
+cperf_check_test_vector(struct cperf_options *opts,
+ struct cperf_test_vector *test_vec)
{
- if (opts.op_type == CPERF_CIPHER_ONLY) {
- if (opts.cipher_algo == RTE_CRYPTO_CIPHER_NULL) {
- if (test_vec.plaintext.data == NULL)
+ if (opts->op_type == CPERF_CIPHER_ONLY) {
+ if (opts->cipher_algo == RTE_CRYPTO_CIPHER_NULL) {
+ if (test_vec->plaintext.data == NULL)
return -1;
- } else if (opts.cipher_algo != RTE_CRYPTO_CIPHER_NULL) {
- if (test_vec.plaintext.data == NULL)
+ } else if (opts->cipher_algo != RTE_CRYPTO_CIPHER_NULL) {
+ if (test_vec->plaintext.data == NULL)
return -1;
- if (test_vec.plaintext.length != opts.buffer_sz)
+ if (test_vec->plaintext.length != opts->buffer_sz)
return -1;
- if (test_vec.ciphertext.data == NULL)
+ if (test_vec->ciphertext.data == NULL)
return -1;
- if (test_vec.ciphertext.length != opts.buffer_sz)
+ if (test_vec->ciphertext.length != opts->buffer_sz)
return -1;
- if (test_vec.iv.data == NULL)
+ if (test_vec->iv.data == NULL)
return -1;
- if (test_vec.iv.length != opts.cipher_iv_sz)
+ if (test_vec->iv.length != opts->cipher_iv_sz)
return -1;
- if (test_vec.cipher_key.data == NULL)
+ if (test_vec->cipher_key.data == NULL)
return -1;
- if (test_vec.cipher_key.length != opts.cipher_key_sz)
+ if (test_vec->cipher_key.length != opts->cipher_key_sz)
return -1;
}
- } else if (opts.op_type == CPERF_AUTH_ONLY) {
- if (opts.auth_algo != RTE_CRYPTO_AUTH_NULL) {
- if (test_vec.plaintext.data == NULL)
+ } else if (opts->op_type == CPERF_AUTH_ONLY) {
+ if (opts->auth_algo != RTE_CRYPTO_AUTH_NULL) {
+ if (test_vec->plaintext.data == NULL)
return -1;
- if (test_vec.plaintext.length != opts.buffer_sz)
+ if (test_vec->plaintext.length != opts->buffer_sz)
return -1;
- if (test_vec.auth_key.data == NULL)
+ if (test_vec->auth_key.data == NULL)
return -1;
- if (test_vec.auth_key.length != opts.auth_key_sz)
+ if (test_vec->auth_key.length != opts->auth_key_sz)
return -1;
- if (test_vec.digest.data == NULL)
+ if (test_vec->digest.data == NULL)
return -1;
- if (test_vec.digest.length != opts.auth_digest_sz)
+ if (test_vec->digest.length != opts->auth_digest_sz)
return -1;
}
- } else if (opts.op_type == CPERF_CIPHER_THEN_AUTH ||
- opts.op_type == CPERF_AUTH_THEN_CIPHER) {
- if (opts.cipher_algo == RTE_CRYPTO_CIPHER_NULL) {
- if (test_vec.plaintext.data == NULL)
+ } else if (opts->op_type == CPERF_CIPHER_THEN_AUTH ||
+ opts->op_type == CPERF_AUTH_THEN_CIPHER) {
+ if (opts->cipher_algo == RTE_CRYPTO_CIPHER_NULL) {
+ if (test_vec->plaintext.data == NULL)
return -1;
- if (test_vec.plaintext.length != opts.buffer_sz)
+ if (test_vec->plaintext.length != opts->buffer_sz)
return -1;
- } else if (opts.cipher_algo != RTE_CRYPTO_CIPHER_NULL) {
- if (test_vec.plaintext.data == NULL)
+ } else if (opts->cipher_algo != RTE_CRYPTO_CIPHER_NULL) {
+ if (test_vec->plaintext.data == NULL)
return -1;
- if (test_vec.plaintext.length != opts.buffer_sz)
+ if (test_vec->plaintext.length != opts->buffer_sz)
return -1;
- if (test_vec.ciphertext.data == NULL)
+ if (test_vec->ciphertext.data == NULL)
return -1;
- if (test_vec.ciphertext.length != opts.buffer_sz)
+ if (test_vec->ciphertext.length != opts->buffer_sz)
return -1;
- if (test_vec.iv.data == NULL)
+ if (test_vec->iv.data == NULL)
return -1;
- if (test_vec.iv.length != opts.cipher_iv_sz)
+ if (test_vec->iv.length != opts->cipher_iv_sz)
return -1;
- if (test_vec.cipher_key.data == NULL)
+ if (test_vec->cipher_key.data == NULL)
return -1;
- if (test_vec.cipher_key.length != opts.cipher_key_sz)
+ if (test_vec->cipher_key.length != opts->cipher_key_sz)
return -1;
}
- if (opts.auth_algo != RTE_CRYPTO_AUTH_NULL) {
- if (test_vec.auth_key.data == NULL)
+ if (opts->auth_algo != RTE_CRYPTO_AUTH_NULL) {
+ if (test_vec->auth_key.data == NULL)
return -1;
- if (test_vec.auth_key.length != opts.auth_key_sz)
+ if (test_vec->auth_key.length != opts->auth_key_sz)
return -1;
- if (test_vec.digest.data == NULL)
+ if (test_vec->digest.data == NULL)
return -1;
- if (test_vec.digest.length != opts.auth_digest_sz)
+ if (test_vec->digest.length != opts->auth_digest_sz)
return -1;
}
- } else if (opts.op_type == CPERF_AEAD) {
- if (test_vec.plaintext.data == NULL)
+ } else if (opts->op_type == CPERF_AEAD) {
+ if (test_vec->plaintext.data == NULL)
return -1;
- if (test_vec.plaintext.length != opts.buffer_sz)
+ if (test_vec->plaintext.length != opts->buffer_sz)
return -1;
- if (test_vec.aad.data == NULL)
+ if (test_vec->aad.data == NULL)
return -1;
- if (test_vec.aad.length != opts.auth_aad_sz)
+ if (test_vec->aad.length != opts->auth_aad_sz)
return -1;
- if (test_vec.digest.data == NULL)
+ if (test_vec->digest.data == NULL)
return -1;
- if (test_vec.digest.length != opts.auth_digest_sz)
+ if (test_vec->digest.length != opts->auth_digest_sz)
return -1;
}
return 0;
@@ -320,7 +320,7 @@
goto err;
}
- if (cperf_check_test_vector(opts, *t_vec)) {
+ if (cperf_check_test_vector(&opts, t_vec)) {
RTE_LOG(ERR, USER1, "Incomplete necessary test vectors"
"\n");
goto err;
--
1.9.1
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
next reply other threads:[~2017-02-08 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 16:04 Jacek Piasecki [this message]
2017-02-08 16:04 ` [dpdk-dev] [PATCH] app/test-crypto-perf: fix incorrect size of expression Jacek Piasecki
2017-02-09 23:53 ` De Lara Guarch, Pablo
2017-02-10 13:26 ` [dpdk-dev] [PATCH v2] " Jacek Piasecki
2017-02-10 11:28 ` De Lara Guarch, Pablo
2017-02-10 11:48 ` De Lara Guarch, Pablo
2017-02-09 23:41 ` [dpdk-dev] [PATCH] app/test-crypto-perf: fix big paremeter passed by value De Lara Guarch, Pablo
2017-02-09 23:48 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486569881-16220-1-git-send-email-jacekx.piasecki@intel.com \
--to=jacekx.piasecki@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).