From: Nipun Gupta <nipun.gupta@nxp.com>
To: <dev@dpdk.org>
Cc: <hemant.agrawal@nxp.com>, <jerin.jacob@caviumnetworks.com>,
<bruce.richardson@intel.com>, <gage.eads@intel.com>,
<harry.van.haaren@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>
Subject: [dpdk-dev] [PATCH] eventdev: amend comments for nb_events_limit and new_event_threshold
Date: Fri, 10 Feb 2017 20:35:04 +0530 [thread overview]
Message-ID: <1486739104-10953-1-git-send-email-nipun.gupta@nxp.com> (raw)
Updated the comments on 'nb_events_limit' of 'struct rte_event_dev_config'
and 'new_event_threshold' of 'struct rte_event_port_conf' for open system
configuration.
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
lib/librte_eventdev/rte_eventdev.h | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index c2f9310..171e52e 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -404,11 +404,12 @@ struct rte_event_dev_config {
* @see RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
*/
int32_t nb_events_limit;
- /**< Applies to *closed system* event dev only. This field indicates a
- * limit to ethdev-like devices to limit the number of events injected
- * into the system to not overwhelm core-to-core events.
+ /**< In a *closed system* this field indicates a limit to ethdev-like
+ * devices to limit the number of events injected into the system to
+ * not overwhelm core-to-core events.
* This value cannot exceed the *max_num_events* which previously
- * provided in rte_event_dev_info_get()
+ * provided in rte_event_dev_info_get().
+ * This should be set to '-1' for *open system*.
*/
uint8_t nb_event_queues;
/**< Number of event queues to configure on this device.
@@ -633,7 +634,8 @@ struct rte_event_port_conf {
* can have a lower threshold so as not to overwhelm the device,
* while ports used for worker pools can have a higher threshold.
* This value cannot exceed the *nb_events_limit*
- * which previously supplied to rte_event_dev_configure()
+ * which previously supplied to rte_event_dev_configure().
+ * This should be set to '-1' for *open system*.
*/
uint8_t dequeue_depth;
/**< Configure number of bulk dequeues for this event port.
--
1.9.1
next reply other threads:[~2017-02-10 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 15:05 Nipun Gupta [this message]
2017-02-10 15:50 ` [dpdk-dev] [PATCH v2] eventdev: amend comments for events limit and threshold Nipun Gupta
2017-02-10 10:31 ` Van Haaren, Harry
2017-02-11 9:48 ` Nipun Gupta
2017-02-13 7:53 ` Jerin Jacob
2017-02-14 12:42 ` [dpdk-dev] [PATCH v3] " Nipun Gupta
2017-02-15 13:53 ` Van Haaren, Harry
2017-02-15 14:56 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486739104-10953-1-git-send-email-nipun.gupta@nxp.com \
--to=nipun.gupta@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).