From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rich Lane <rich.lane@bigswitch.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix leak of fds and mmaps
Date: Fri, 19 Feb 2016 16:08:32 +0100 [thread overview]
Message-ID: <14867543.eEYu7dpNMI@xps13> (raw)
In-Reply-To: <1455129655-25520-1-git-send-email-rlane@bigswitch.com>
2016-02-10 10:40, Rich Lane:
> The common vhost code only supported a single mmap per device. vhost-user
> worked around this by saving the address/length/fd of each mmap after the end
> of the rte_virtio_memory struct. This only works if the vhost-user code frees
> dev->mem, since the common code is unaware of the extra info. The
> VHOST_USER_RESET_OWNER message is one situation where the common code frees
> dev->mem and leaks the fds and mappings. This happens every time I shut down a
> VM.
>
> The new code calls back into the implementation (vhost-user or vhost-cuse) to
> clean up these resources.
>
> The vhost-cuse changes are only compile tested.
>
> Signed-off-by: Rich Lane <rlane@bigswitch.com>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Applied, thanks
prev parent reply other threads:[~2016-02-19 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 22:14 [dpdk-dev] [PATCH] " Rich Lane
2016-01-07 2:31 ` Yuanhan Liu
2016-01-07 6:50 ` Xie, Huawei
2016-01-17 19:57 ` [dpdk-dev] [PATCH v2 1/1] " Rich Lane
2016-01-18 7:58 ` Yuanhan Liu
2016-01-19 18:13 ` Rich Lane
2016-02-06 5:23 ` Yuanhan Liu
2016-02-10 18:40 ` [dpdk-dev] [PATCH v3] " Rich Lane
2016-02-19 15:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14867543.eEYu7dpNMI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=rich.lane@bigswitch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).