DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yong Wang <wang.yong19@zte.com.cn>
To: jan@semihalf.com
Cc: dev@dpdk.org, Yong Wang <wang.yong19@zte.com.cn>
Subject: [dpdk-dev] [PATCH 2/2] net/ena: fix return of hash control flushing
Date: Tue, 14 Feb 2017 07:37:43 -0500	[thread overview]
Message-ID: <1487075863-3056-2-git-send-email-wang.yong19@zte.com.cn> (raw)
In-Reply-To: <1487075863-3056-1-git-send-email-wang.yong19@zte.com.cn>

In function ena_com_set_hash_ctrl(), the return value is assigned to
"ret" variable, but it is not returned. Fix it by adding the return.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/ena/base/ena_com.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index 39356d2..38a0587 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -2278,7 +2278,7 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
 					    sizeof(resp));
 	if (unlikely(ret)) {
 		ena_trc_err("Failed to set hash input. error: %d\n", ret);
-		ret = ENA_COM_INVAL;
+		return ENA_COM_INVAL;
 	}
 
 	return 0;
-- 
1.8.3.1

  reply	other threads:[~2017-02-14 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 12:37 [dpdk-dev] [PATCH 1/2] net/ena: remove redundant variable Yong Wang
2017-02-14 12:37 ` Yong Wang [this message]
2017-03-14 17:59   ` [dpdk-dev] [PATCH 2/2] net/ena: fix return of hash control flushing Jan Mędala
2017-03-14 18:11     ` Ferruh Yigit
2017-03-14 17:59 ` [dpdk-dev] [PATCH 1/2] net/ena: remove redundant variable Jan Mędala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487075863-3056-2-git-send-email-wang.yong19@zte.com.cn \
    --to=wang.yong19@zte.com.cn \
    --cc=dev@dpdk.org \
    --cc=jan@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).