From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id E8F96B10A
 for <dev@dpdk.org>; Thu, 12 Jun 2014 00:50:09 +0200 (CEST)
Received: by mail-wi0-f174.google.com with SMTP id bs8so2544715wib.7
 for <dev@dpdk.org>; Wed, 11 Jun 2014 15:50:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=AYdF9OI74QicyxqV3Vyj4epTrSpsIkySUzN4bOxAvrE=;
 b=jKt+4NhXV3WIrGaM0H7Hch1OySRsUy89X7va5JL++8x3L3dMxhdQXZDuzqe9Zh/Vfg
 twB53eQ12QwhnwcVWd4x0cTZKAFFEpUfVEyT0mZ3a7QXYBPSl3F31MxxEJ1co7ZOT1sj
 EgpUQbf81Y8HZr2yZXjzksHp1yv9u3jMhpSP5f0UF4nvwBIghDCph8BqEfuzl5WDtF/l
 cmo+UbrndA8fMg7qSy3JeUGrlJUedFj+3M0eblZ40vimhfIyx7pDQfEPDGqxoOPuQTX5
 dRS8jwuWpN8oCNwWFKO9RFFCvhJq6tvG2WbOTVwCOGVh2+E1SQ2OAR+R0KgaukEzEODU
 OsrQ==
X-Gm-Message-State: ALoCoQl4vkxUbvzCE+Sx4DaWY7nHzTJ1zi6Z9v9p1jhH5PDIMXej/QMY9tRQOi6Gh4/YD+/ike1D
X-Received: by 10.194.77.177 with SMTP id t17mr30649694wjw.55.1402527024809;
 Wed, 11 Jun 2014 15:50:24 -0700 (PDT)
Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr.
 [80.236.123.96])
 by mx.google.com with ESMTPSA id fh5sm29758531wic.9.2014.06.11.15.50.23
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 11 Jun 2014 15:50:24 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Date: Thu, 12 Jun 2014 00:50:24 +0200
Message-ID: <1487472.hZgYJQSpCy@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA35210@IRSMSX103.ger.corp.intel.com>
References: <1402519509-26653-1-git-send-email-Patrick.Lu@intel.com>
 <9007853.cgh6aaULN3@xps13>
 <59AF69C657FD0841A61C55336867B5B01AA35210@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 22:50:10 -0000

2014-06-11 21:57, Richardson, Bruce:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > 2014-06-11 13:45, Patrick Lu:
> > > The new API rte_lcore_id2() will return an index from enabled lcores
> > > starting from zero.
> > 
> > I think core_id2 is not a representative name.
> > What do you think of renaming core_id as lcore_hwid and core_id2 as
> > lcore_index?
> 
> I like lcore_index as the name for the new function. However, I'm not sure
> in that case that we want/need to rename the old one.

I think it would be not easy to distinguish id and index. So I prefer 
hwid/index. And lcore is more precise than core.

-- 
Thomas