From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 3E6B22C5E for ; Mon, 27 Feb 2017 08:52:14 +0100 (CET) Received: from pps.filterd (m0085408.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1R7qCo3008335; Sun, 26 Feb 2017 23:52:12 -0800 Received: from avcashub1.qlogic.com ([198.186.0.116]) by mx0b-0016ce01.pphosted.com with ESMTP id 28ut281un0-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 26 Feb 2017 23:52:11 -0800 Received: from avluser05.qlc.com (10.1.113.115) by qlc.com (10.1.4.191) with Microsoft SMTP Server id 14.3.235.1; Sun, 26 Feb 2017 23:52:10 -0800 Received: (from rmody@localhost) by avluser05.qlc.com (8.14.4/8.14.4/Submit) id v1R7qA2c009710; Sun, 26 Feb 2017 23:52:10 -0800 X-Authentication-Warning: avluser05.qlc.com: rmody set sender to rasesh.mody@cavium.com using -f From: Rasesh Mody To: CC: Rasesh Mody , Date: Sun, 26 Feb 2017 23:51:44 -0800 Message-ID: <1488181923-9649-2-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> References: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain disclaimer: bypass X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8451 signatures=669242 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1702270080 Subject: [dpdk-dev] [PATCH 02/21] net/qede/base: fix to set pointers to NULL after freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 07:52:15 -0000 Set pointers to NULL after freeing the allocations on ecore_resc_free(). Fixes: 26ae839d06e9 ("qede: add DCBX support") Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 2 +- drivers/net/qede/base/ecore_dev.c | 4 ++-- drivers/net/qede/base/ecore_spq.c | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 7380fd8..9ce6dc4 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -914,7 +914,7 @@ enum _ecore_status_t ecore_dcbx_info_alloc(struct ecore_hwfn *p_hwfn) void ecore_dcbx_info_free(struct ecore_hwfn *p_hwfn, struct ecore_dcbx_info *p_dcbx_info) { - OSAL_FREE(p_hwfn->p_dev, p_hwfn->p_dcbx_info); + p_hwfn->p_dcbx_info = OSAL_NULL; } static void ecore_dcbx_update_protocol_data(struct protocol_dcb_data *p_data, diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index 0518fc7..15051b6 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -156,6 +156,7 @@ void ecore_resc_free(struct ecore_dev *p_dev) p_dev->fw_data = OSAL_NULL; OSAL_FREE(p_dev, p_dev->reset_stats); + p_dev->reset_stats = OSAL_NULL; for_each_hwfn(p_dev, i) { struct ecore_hwfn *p_hwfn = &p_dev->hwfns[i]; @@ -668,8 +669,7 @@ enum _ecore_status_t ecore_resc_alloc(struct ecore_dev *p_dev) DP_ERR(p_hwfn, "Cannot allocate 0x%x EQ elements." "The maximum of a u16 chain is 0x%x\n", n_eqes, 0xFFFF); - rc = ECORE_INVAL; - goto alloc_err; + goto alloc_no_mem; } p_eq = ecore_eq_alloc(p_hwfn, (u16)n_eqes); diff --git a/drivers/net/qede/base/ecore_spq.c b/drivers/net/qede/base/ecore_spq.c index 1f35d6c..d55a448 100644 --- a/drivers/net/qede/base/ecore_spq.c +++ b/drivers/net/qede/base/ecore_spq.c @@ -402,6 +402,7 @@ void ecore_eq_free(struct ecore_hwfn *p_hwfn, struct ecore_eq *p_eq) return; ecore_chain_free(p_hwfn->p_dev, &p_eq->chain); OSAL_FREE(p_hwfn->p_dev, p_eq); + p_eq = OSAL_NULL; } /*************************************************************************** @@ -987,4 +988,5 @@ void ecore_consq_free(struct ecore_hwfn *p_hwfn, struct ecore_consq *p_consq) return; ecore_chain_free(p_hwfn->p_dev, &p_consq->chain); OSAL_FREE(p_hwfn->p_dev, p_consq); + p_consq = OSAL_NULL; } -- 1.7.10.3