From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com [67.231.148.157]) by dpdk.org (Postfix) with ESMTP id 1D3F82C5E for ; Mon, 27 Feb 2017 08:52:15 +0100 (CET) Received: from pps.filterd (m0095336.ppops.net [127.0.0.1]) by mx0a-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1R7l20e002408; Sun, 26 Feb 2017 23:52:13 -0800 Received: from avcashub1.qlogic.com ([198.186.0.115]) by mx0a-0016ce01.pphosted.com with ESMTP id 28u8w8k21w-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 26 Feb 2017 23:52:12 -0800 Received: from avluser05.qlc.com (10.1.113.115) by avcashub1.qlogic.org (10.1.4.190) with Microsoft SMTP Server (TLS) id 14.3.235.1; Sun, 26 Feb 2017 23:52:12 -0800 Received: (from rmody@localhost) by avluser05.qlc.com (8.14.4/8.14.4/Submit) id v1R7qCHm009711; Sun, 26 Feb 2017 23:52:12 -0800 X-Authentication-Warning: avluser05.qlc.com: rmody set sender to rasesh.mody@cavium.com using -f From: Rasesh Mody To: CC: Rasesh Mody , Date: Sun, 26 Feb 2017 23:51:45 -0800 Message-ID: <1488181923-9649-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> References: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain disclaimer: bypass X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8451 signatures=669242 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1702270079 Subject: [dpdk-dev] [PATCH 03/21] net/qede/base: fix forcing driver default resc allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 07:52:16 -0000 Remove the forcing of the driver's default resource allocation. Fixes: 77f7222124de ("net/qede: add PCI ids for new chip variant") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index 15051b6..e0b6843 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2306,12 +2306,11 @@ static enum _ecore_status_t ecore_hw_set_resc_info(struct ecore_hwfn *p_hwfn, *p_resc_start = resc_info.offset; if (*p_resc_num != dflt_resc_num || *p_resc_start != dflt_resc_start) { - DP_NOTICE(p_hwfn, false, - "Resource %d [%s]: MFW allocation [num %d, start %d]" - " differs from default values [num %d, start %d]%s\n", - res_id, ecore_hw_get_resc_name(res_id), *p_resc_num, - *p_resc_start, dflt_resc_num, dflt_resc_start, - drv_resc_alloc ? " - Applying default values" : ""); + DP_INFO(p_hwfn, + "Resource %d [%s]: MFW allocation [num %d, start %d] differs from default values [num %d, start %d]%s\n", + res_id, ecore_hw_get_resc_name(res_id), *p_resc_num, + *p_resc_start, dflt_resc_num, dflt_resc_start, + drv_resc_alloc ? " - Applying default values" : ""); if (drv_resc_alloc) { *p_resc_num = dflt_resc_num; *p_resc_start = dflt_resc_start; @@ -2340,12 +2339,7 @@ static enum _ecore_status_t ecore_hw_get_resc(struct ecore_hwfn *p_hwfn, #endif for (res_id = 0; res_id < ECORE_MAX_RESC; res_id++) { - /* @@@TMP for AH: - * Force the driver's default resource allocation in case there - * is a diff with the MFW allocation value. - */ - rc = ecore_hw_set_resc_info(p_hwfn, res_id, - b_ah || drv_resc_alloc); + rc = ecore_hw_set_resc_info(p_hwfn, res_id, drv_resc_alloc); if (rc != ECORE_SUCCESS) return rc; } -- 1.7.10.3