From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D839A04B1; Mon, 23 Nov 2020 14:50:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 607BEC8C4; Mon, 23 Nov 2020 14:50:14 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id 7D0D5160 for ; Mon, 23 Nov 2020 14:50:11 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id EFB037F543; Mon, 23 Nov 2020 16:50:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru EFB037F543 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1606139410; bh=pbgQdH7JNeh36ikQA08g+3JygtzHjFsTQRmXFdprCGw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=clrNvhNvGp8WU+34QjpymEYNaI1DGvX/O8jcTB7aN396D3lcUYl9iV3KIFcs2rd61 ET97vsjbpvcU628IRAb8vSThCyvbqnMAg9ugMbjkexg1/rWzFral0HuACyWXXA6Sfp W+849bXmV7Q8NJcXXYKSX0MmcMNpQofqn8JK2mo0= To: Ferruh Yigit , Ray Kinsella , Neil Horman Cc: dev@dpdk.org, Thomas Monjalon , Ori Kam References: <20201123134007.2870297-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <148925d7-2ebd-fcbb-0d7c-6cbe3d15a6de@oktetlabs.ru> Date: Mon, 23 Nov 2020 16:50:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201123134007.2870297-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce flow API matching pattern struct changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/23/20 4:40 PM, Ferruh Yigit wrote: > Proposing to replace protocol header fields in the ``rte_flow_item_*`` > structures with the protocol structs, like: > > Current ``struct rte_flow_item_eth``, > > struct rte_flow_item_eth { > struct rte_ether_addr dst; > struct rte_ether_addr src; > rte_be16_t type; > uint32_t has_vlan:1; > uint32_t reserved:31; > } > > will become > > struct rte_flow_item_eth { > struct rte_ether_hdr hdr; > uint32_t has_vlan:1; > uint32_t reserved:31; > } > > This is both for documenting the intention and to be sure > ``rte_flow_item_*`` always starts with complete protocol header. > > Already many ``rte_flow_item_*`` structs implemented to have protocol > struct, target is convert all to this usage. > > Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko a minor note below > --- > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > Cc: Ori Kam > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 96986fabd598..a2fa0c196472 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -88,6 +88,13 @@ Deprecation Notices > will be limited to maximum 256 queues. > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. > > +* ethdev: The flow API matching pattern structures, ``struct rte_flow_item_*``, > + should start with relevant protocol header. > + Some matching pattern structures implements this by duplicating protocol header > + fields in the struct. To clarify the intention and to be sure protocol header > + is intact, will replace those fields with relevant protocol header struct. > + Target is v21.02 release and this should not change the ABI. > + > * sched: To allow more traffic classes, flexible mapping of pipe queues to > traffic classes, and subport level configuration of pipes and queues > changes will be made to macros, data structures and API functions defined > Just want to highlight that even API could be kept using unnamed union for hdr and unnamed structure for existing protocol header fields.