From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>, dev@dpdk.org
Cc: olivier.matz@6wind.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net: fix compilation with pedantic enabled
Date: Tue, 21 Jul 2020 16:43:38 +0100 [thread overview]
Message-ID: <148d6bb7-e93f-032e-f9f9-bc23c4deb736@intel.com> (raw)
In-Reply-To: <1595320315-15549-1-git-send-email-rasland@mellanox.com>
On 7/21/2020 9:31 AM, Raslan Darawsheh wrote:
> when trying to compile rte_mpls with pedantic enabled,
> on old compilers like 4.8 it will complain about bit field definition.
>
> error: type of bit-field 'bs' is a GCC extension [-Werror=pedantic]
> error: type of bit-field 'tc' is a GCC extension [-Werror=pedantic]
> error: type of bit-field 'tag_lsb' is a GCC extension [-Werror=pedantic]
>
> This fixes the compilation error by adding extension to the header
> definition.
>
> Fixes: e480cf487a0d ("net: add MPLS header structure")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-07-21 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:12 [dpdk-dev] [PATCH] " Raslan Darawsheh
2020-07-21 0:05 ` Ferruh Yigit
2020-07-21 7:09 ` Olivier Matz
2020-07-21 7:37 ` Raslan Darawsheh
2020-07-21 7:50 ` Olivier Matz
2020-07-21 8:11 ` Raslan Darawsheh
2020-07-21 8:31 ` [dpdk-dev] [PATCH v2] " Raslan Darawsheh
2020-07-21 15:43 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148d6bb7-e93f-032e-f9f9-bc23c4deb736@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).