DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jingjing Wu <jingjing.wu@intel.com>
To: dev@dpdk.org
Cc: jingjing.wu@intel.com, helin.zhang@intel.com,
	beilei.xing@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 3/7] net/i40e/base: fix potential out of bound array access
Date: Wed, 22 Mar 2017 17:24:55 +0800	[thread overview]
Message-ID: <1490174699-147026-4-git-send-email-jingjing.wu@intel.com> (raw)
In-Reply-To: <1490174699-147026-1-git-send-email-jingjing.wu@intel.com>

This is fix for klocwork issue where dcbcfg->numapps could
be greater than size of array (i.e dcbcfg->app[I40E_DCBX_MAX_APPS]).
The fix makes sure the array is not accessed past size of array
(i.e. I40E_DCBX_MAX_APPS).

Fixes: 166dceeeeafc ("i40e/base: add parsing for CEE DCBX TLVs")
Cc: stable@dpdk.org
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/base/i40e_dcb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/i40e/base/i40e_dcb.c b/drivers/net/i40e/base/i40e_dcb.c
index 26c344f..9b5405d 100644
--- a/drivers/net/i40e/base/i40e_dcb.c
+++ b/drivers/net/i40e/base/i40e_dcb.c
@@ -396,6 +396,8 @@ static void i40e_parse_cee_app_tlv(struct i40e_cee_feat_tlv *tlv,
 	dcbcfg->numapps = length / sizeof(*app);
 	if (!dcbcfg->numapps)
 		return;
+	if (dcbcfg->numapps > I40E_DCBX_MAX_APPS)
+		dcbcfg->numapps = I40E_DCBX_MAX_APPS;
 
 	for (i = 0; i < dcbcfg->numapps; i++) {
 		u8 up, selector;
-- 
2.4.11

  parent reply	other threads:[~2017-03-22  9:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22  9:24 [dpdk-dev] [PATCH 0/7] net/i40e: base code update Jingjing Wu
2017-03-22  9:24 ` [dpdk-dev] [PATCH 1/7] net/i40e/base: define bit for HW ATR evict control Jingjing Wu
2017-03-22  9:24 ` [dpdk-dev] [PATCH 2/7] net/i40e/base: control register read/write on X722 Jingjing Wu
2017-03-22  9:24 ` Jingjing Wu [this message]
2017-03-22  9:24 ` [dpdk-dev] [PATCH 4/7] net/i40e/base: new AQ commands for ppp Jingjing Wu
2017-03-22  9:24 ` [dpdk-dev] [PATCH 5/7] net/i40e/base: reduce wait time for adminq command Jingjing Wu
2017-03-22  9:24 ` [dpdk-dev] [PATCH 6/7] net/i40e/base: add VF offload flags Jingjing Wu
2017-03-22  9:24 ` [dpdk-dev] [PATCH 7/7] net/i40e/base: new AQ commands for cloud filter Jingjing Wu
2017-03-22 14:29 ` [dpdk-dev] [PATCH 0/7] net/i40e: base code update Ferruh Yigit
2017-03-23  1:26   ` Wu, Jingjing
2017-03-23 10:05     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490174699-147026-4-git-send-email-jingjing.wu@intel.com \
    --to=jingjing.wu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).