From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 5F5072956 for <dev@dpdk.org>; Wed, 6 Apr 2016 11:35:48 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id n3so54703224wmn.0 for <dev@dpdk.org>; Wed, 06 Apr 2016 02:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ztPc3xcMSjGy43bdnuMSbTyLP8sCHdK0lkOGo9JfBWI=; b=ObQfbHCzRPUhV1qKD/DyYD1GK2qHpq9U7h0TgqsS4ytjn8GFWIneRfUs+hLznX+88T upiCz79cfCF8vz0r/ZrKoFMiTzLuwzswo9/bte3DFR2uLB7AkJC5n42lTp3aRnI0Ungq fhxR2Tqp7npKNaRExdKV5+GZNlE1oQqolQFvS95I5DfL9djDyeRfYgRtbncEPrTiWsL7 aOxEwNTN/D6ZL3n8x3e6KnC5hyJ7sbHbtNkW4pD9Dxr2ICTpqMh2dOywsF19h9N6wzhX JhGh/YlW1hY7M/K5ZOipsRLH/D9L+pX6DkRrIbvrFsop753dA0hZwAp4EMnQOTPwB41E 8ILg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=ztPc3xcMSjGy43bdnuMSbTyLP8sCHdK0lkOGo9JfBWI=; b=IE47NOrX3tpa366aUxNIySd2GRmKhlp2wE8wOpRHu0aEiUxRvCy6vXvMo+i1sRTHnc Im8vNA54pGYxjLIcJo/vIAKRoBwJNE52YMOLH+LHEZiNdJNz/Hv8yy480MfeSHbatXxL t6b1QWZ2c9YCVLe7w1qSEGC18aBUGgpPMVhh3DOF82oqPb5sGeW+7llzu+5jlIHydpj3 vAeLL1+QEMQv7bhUz5uwTUrdvpdCXaw2u3uC5YfBqo1uxoNYGqcFnwMoUTjcyUgWhT28 Onr/ygEWGz/fu0ZvWbuW9VyTbmlNyj2kupkb1PDQ/hv7wu3WgeM14q5EN55LlFsKiMFM T38A== X-Gm-Message-State: AD7BkJIp3sm/mV4QkV1Xsm9f3kPm68nIZxC8bWAAZUrLd0iF7UWJdPmM+6/+AQoRDFRc2Mjz X-Received: by 10.28.146.202 with SMTP id u193mr23122880wmd.82.1459935348223; Wed, 06 Apr 2016 02:35:48 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id gt7sm2305970wjc.1.2016.04.06.02.35.47 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 02:35:47 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Weglicki, MichalX" <michalx.weglicki@intel.com> Cc: Marc Sune <marcdevel@gmail.com>, "Xu, Qian Q" <qian.q.xu@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, dev@dpdk.org, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Glynn, Michael J" <michael.j.glynn@intel.com>, "Gray, Mark D" <mark.d.gray@intel.com> Date: Wed, 06 Apr 2016 11:34:10 +0200 Message-ID: <1490664.EjhaX1bMBJ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1AFA2937E172CD4DB2FD9318443C060EE957C1@IRSMSX103.ger.corp.intel.com> References: <1458934950-23333-1-git-send-email-thomas.monjalon@6wind.com> <1510689.gPteTu5Ds8@xps13> <1AFA2937E172CD4DB2FD9318443C060EE957C1@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 06 Apr 2016 09:35:48 -0000 2016-04-06 09:16, Weglicki, MichalX: > Hello, > > Thank you for your answer. > > I didn't mention that patch is cosmetic, rather naming. > > But all clear, I somehow missed it 9 months ago, and couldn't find it. > > Is there any official place where I can find upcoming ABI & API changes, or I have to dig through mailing list? Yes, the API and ABI changes are described in the release notes: http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_16_04.rst#n471 And the next deprecations are announced in another section: http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/deprecation.rst PS: please answer inline ----------------- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-04-06 08:34, Weglicki, MichalX: > > Hello, > > > > I have a question about this patch. > > > > As far as I see changing ETH_LINK_SPEED_ to ETH_SPEED_NUM_ is rather cosmetic change, am I right? > > No. > ETH_LINK_SPEED was used for configuration and reported speed. > Now the configuration is done with a bitmap filled with new ETH_LINK_SPEED > and the old numerical values are kept for other usages as ETH_SPEED_NUM. > > > Disadvantage of that is that it breaks compatibility with OVS (compilation) and thus it also breaks backward compatibility between OVS & DPDK. Is it really necessary? > > Yes that's why this change was discussed 9 months ago and announced in the > previous release notes. > > > It would be great to keep ABI & API stable if possible. > > We try to keep it stable when possible and continue to bring some improvements.