DPDK patches and discussions
 help / color / mirror / Atom feed
From: henry <caihe@huawei.com>
To: <helin.zhang@intel.com>
Cc: <dev@dpdk.org>, <jingjing.wu@intel.com>, <wangyunjian@huawei.com>,
	<zhoujingbin@huawei.com>, henry <caihe@huawei.com>
Subject: [dpdk-dev] [PATCH v2] net/i40e: fix a bug in function i40evf_add_del_all_mac_addr
Date: Tue, 28 Mar 2017 16:19:27 +0800	[thread overview]
Message-ID: <1490689167-8660-1-git-send-email-caihe@huawei.com> (raw)

check return value of rte_zmalloc

Signed-off-by: henry <caihe@huawei.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 55fd344..fdb5be6 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2014,6 +2014,12 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,
 		}
 
 		list = rte_zmalloc("i40evf_del_mac_buffer", len, 0);
+		if (!list) {
+			PMD_DRV_LOG(ERR, "abort execute command %s",
+				    add ? "OP_ADD_ETHER_ADDRESS" :
+				    "OP_DEL_ETHER_ADDRESS");
+			return;
+		}
 
 		for (i = begin; i < next_begin; i++) {
 			addr = &dev->data->mac_addrs[i];
-- 
1.8.3.1

             reply	other threads:[~2017-03-28  8:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  8:19 henry [this message]
2017-03-28  8:44 ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490689167-8660-1-git-send-email-caihe@huawei.com \
    --to=caihe@huawei.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=wangyunjian@huawei.com \
    --cc=zhoujingbin@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).