DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: [dpdk-dev] [PATCH v2 1/1] pci: default to whitelist mode
Date: Tue, 28 Mar 2017 14:01:29 +0200	[thread overview]
Message-ID: <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> (raw)
In-Reply-To: <1490701917-17089-1-git-send-email-gaetan.rivet@6wind.com>

Expects all devices to be explicitly defined before being probed.

The blacklist mode can be prone to errors, coaxing users in capturing
devices that could be used for management or otherwise.
The whitelist mode offers users more control and highlight mistakes by
making them visible on the command line.

This is more useful to have a clear idea of the state of the system used,
which is better in the context of standalone / headless applications.

Using the -b option will revert to the original behavior.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
v2: justify this default behavior evolution.
---
 lib/librte_eal/common/eal_common_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 15a0c48..ad0a8be 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -418,7 +418,7 @@ rte_eal_pci_probe(void)
 	int probe_all = 0;
 	int ret = 0;
 
-	if (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) == 0)
+	if (rte_eal_devargs_type_count(RTE_DEVTYPE_BLACKLISTED_PCI) > 0)
 		probe_all = 1;
 
 	TAILQ_FOREACH(dev, &pci_device_list, next) {
-- 
2.1.4

  parent reply	other threads:[~2017-03-28 12:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 11:51 [dpdk-dev] [PATCH " Gaetan Rivet
2017-03-28 11:58 ` Bruce Richardson
2017-03-28 12:05   ` Gaëtan Rivet
2017-03-28 12:01 ` Gaetan Rivet [this message]
2017-03-28 12:20   ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2017-03-28 12:44     ` Gaëtan Rivet
2017-03-28 13:02       ` Van Haaren, Harry
2017-03-28 13:53         ` Gaëtan Rivet
2017-03-30 19:36         ` Thomas Monjalon
2017-03-28 13:03       ` Bruce Richardson
2017-03-28 13:35         ` Gaëtan Rivet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).