* [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release @ 2017-03-29 15:08 Andrew Rybchenko 2017-03-29 16:25 ` Ferruh Yigit 2017-03-29 16:53 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko 0 siblings, 2 replies; 6+ messages in thread From: Andrew Rybchenko @ 2017-03-29 15:08 UTC (permalink / raw) To: dev Datapath TxQ handle is passed to release function, not control path. Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath") Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- Please, squash the patch into 5808dbaf751f. drivers/net/sfc/sfc_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index b745714..bba8b01 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -485,13 +485,15 @@ sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id, static void sfc_tx_queue_release(void *queue) { - struct sfc_txq *txq = queue; + struct sfc_dp_txq *dp_txq = queue; + struct sfc_txq *txq; unsigned int sw_index; struct sfc_adapter *sa; - if (txq == NULL) + if (dp_txq == NULL) return; + txq = sfc_txq_by_dp_txq(dp_txq); sw_index = sfc_txq_sw_index(txq); SFC_ASSERT(txq->evq != NULL); -- 2.9.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release 2017-03-29 15:08 [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release Andrew Rybchenko @ 2017-03-29 16:25 ` Ferruh Yigit 2017-03-29 16:37 ` Andrew Rybchenko 2017-03-29 16:53 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko 1 sibling, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2017-03-29 16:25 UTC (permalink / raw) To: Andrew Rybchenko, dev On 3/29/2017 4:08 PM, Andrew Rybchenko wrote: > Datapath TxQ handle is passed to release function, not control path. > > Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath") > > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> > --- > Please, squash the patch into 5808dbaf751f. Hi Andrew, To clarify, for the commits in next-net tree that are not merged yet, we can benefit from sub-tree re-writable option and squash some fixes, -without over using it. But for this patch, as far as I can see, original code added with commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues") which is part of v17.02 release. So, please send a patch with correct fixes line and it won't be squashed. Thanks, ferruh ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release 2017-03-29 16:25 ` Ferruh Yigit @ 2017-03-29 16:37 ` Andrew Rybchenko 2017-03-29 16:59 ` Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Andrew Rybchenko @ 2017-03-29 16:37 UTC (permalink / raw) To: Ferruh Yigit, dev On 03/29/2017 07:25 PM, Ferruh Yigit wrote: > On 3/29/2017 4:08 PM, Andrew Rybchenko wrote: >> Datapath TxQ handle is passed to release function, not control path. >> >> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath") >> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> >> --- >> Please, squash the patch into 5808dbaf751f. > Hi Andrew, Hi Ferruh, > To clarify, for the commits in next-net tree that are not merged yet, we > can benefit from sub-tree re-writable option and squash some fixes, > -without over using it. Yes, it is perfectly clear. > But for this patch, as far as I can see, original code added with > commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues") > which is part of v17.02 release. If we take a look a lines, yes, these lines belong to b1b7ad933b39 ("net/sfc: set up and release Tx queues") however the breakage is introduced by 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") since it registers pointer to the so-called datapath Tx queue in the device data instead of previous used control path Tx queue pointer. > So, please send a patch with correct fixes line and it won't be squashed. Correct fixes line for the patch with current dpdk-next-net is: Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") which is in dpdk-next-net tree only. Should I resend it? Thanks, Andrew. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release 2017-03-29 16:37 ` Andrew Rybchenko @ 2017-03-29 16:59 ` Ferruh Yigit 0 siblings, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2017-03-29 16:59 UTC (permalink / raw) To: Andrew Rybchenko, dev On 3/29/2017 5:37 PM, Andrew Rybchenko wrote: > On 03/29/2017 07:25 PM, Ferruh Yigit wrote: >> On 3/29/2017 4:08 PM, Andrew Rybchenko wrote: >>> Datapath TxQ handle is passed to release function, not control path. >>> >>> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath") >>> >>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> >>> --- >>> Please, squash the patch into 5808dbaf751f. >> Hi Andrew, > > Hi Ferruh, > >> To clarify, for the commits in next-net tree that are not merged yet, we >> can benefit from sub-tree re-writable option and squash some fixes, >> -without over using it. > > Yes, it is perfectly clear. > >> But for this patch, as far as I can see, original code added with >> commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues") >> which is part of v17.02 release. > > If we take a look a lines, yes, these lines belong to > b1b7ad933b39 ("net/sfc: set up and release Tx queues") > however the breakage is introduced by > 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") > since it registers pointer to the so-called datapath Tx queue in the > device data > instead of previous used control path Tx queue pointer. Oh, I see now, I was checking updated lines. > >> So, please send a patch with correct fixes line and it won't be squashed. > > Correct fixes line for the patch with current dpdk-next-net is: > > Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") > > which is in dpdk-next-net tree only. Should I resend it? I saw you already sent another patch, that is good, thanks. > > Thanks, > Andrew. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] net/sfc: fix crash on Tx queue release 2017-03-29 15:08 [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release Andrew Rybchenko 2017-03-29 16:25 ` Ferruh Yigit @ 2017-03-29 16:53 ` Andrew Rybchenko 2017-03-31 12:31 ` Ferruh Yigit 1 sibling, 1 reply; 6+ messages in thread From: Andrew Rybchenko @ 2017-03-29 16:53 UTC (permalink / raw) To: dev; +Cc: Ferruh Yigit Datapath TxQ handle is passed to release function, not control path. Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- Please, squash the patch into 19f92f3ec37c. drivers/net/sfc/sfc_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index b745714..bba8b01 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -485,13 +485,15 @@ sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id, static void sfc_tx_queue_release(void *queue) { - struct sfc_txq *txq = queue; + struct sfc_dp_txq *dp_txq = queue; + struct sfc_txq *txq; unsigned int sw_index; struct sfc_adapter *sa; - if (txq == NULL) + if (dp_txq == NULL) return; + txq = sfc_txq_by_dp_txq(dp_txq); sw_index = sfc_txq_sw_index(txq); SFC_ASSERT(txq->evq != NULL); -- 2.9.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/sfc: fix crash on Tx queue release 2017-03-29 16:53 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko @ 2017-03-31 12:31 ` Ferruh Yigit 0 siblings, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2017-03-31 12:31 UTC (permalink / raw) To: Andrew Rybchenko, dev On 3/29/2017 5:53 PM, Andrew Rybchenko wrote: > Datapath TxQ handle is passed to release function, not control path. > > Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") > > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> > --- > Please, squash the patch into 19f92f3ec37c. In next-net, squashed on top of relevant commit, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-31 12:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-29 15:08 [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release Andrew Rybchenko 2017-03-29 16:25 ` Ferruh Yigit 2017-03-29 16:37 ` Andrew Rybchenko 2017-03-29 16:59 ` Ferruh Yigit 2017-03-29 16:53 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko 2017-03-31 12:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).