From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A82932BB0 for ; Thu, 30 Mar 2017 18:51:38 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 30 Mar 2017 09:51:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,247,1486454400"; d="scan'208";a="81058198" Received: from silpixa00381633.ir.intel.com (HELO silpixa00381633.ger.corp.intel.com) ([10.237.222.114]) by orsmga005.jf.intel.com with ESMTP; 30 Mar 2017 09:51:36 -0700 From: Fan Zhang To: dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, sergio.gonzalez.monroy@intel.com, declan.doherty@intel.com Date: Thu, 30 Mar 2017 17:53:14 +0100 Message-Id: <1490892794-66488-1-git-send-email-roy.fan.zhang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487592849-45645-1-git-send-email-roy.fan.zhang@intel.com> References: <1487592849-45645-1-git-send-email-roy.fan.zhang@intel.com> Subject: [dpdk-dev] [PATCH v2] crypto/scheduler: improve commandline parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 16:51:39 -0000 This patch improves the cryptodev scheduler PMD's commandline parsing capability. Originally, the scheduler's slave option requires the slave vdev(s) being declared prior to it. This patch removes this limitation by storing the slave names temporarily and attaching them later. This patch depends on the following patch: "[dpdk-dev,v2] crypto/scheduler: add more EAL options" (http://dpdk.org/dev/patchwork/patch/22917/) Signed-off-by: Fan Zhang --- v2: - Rebased on top of HEAD. - Updated for depended patch. drivers/crypto/scheduler/scheduler_pmd.c | 88 ++++++++++++++---------- drivers/crypto/scheduler/scheduler_pmd_ops.c | 71 ++++++++++++++++++- drivers/crypto/scheduler/scheduler_pmd_private.h | 3 + 3 files changed, 123 insertions(+), 39 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index dc7192f..50c6a1d 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -44,7 +44,8 @@ struct scheduler_init_params { struct rte_crypto_vdev_init_params def_p; uint32_t nb_slaves; - uint8_t slaves[RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES]; + char slave_names[RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES] + [RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN]; }; #define RTE_CRYPTODEV_VDEV_NAME ("name") @@ -62,37 +63,13 @@ const char *scheduler_valid_params[] = { }; static int -attach_init_slaves(uint8_t scheduler_id, - const uint8_t *slaves, const uint8_t nb_slaves) -{ - uint8_t i; - - for (i = 0; i < nb_slaves; i++) { - struct rte_cryptodev *dev = - rte_cryptodev_pmd_get_dev(slaves[i]); - int status = rte_cryptodev_scheduler_slave_attach( - scheduler_id, slaves[i]); - - if (status < 0 || !dev) { - CS_LOG_ERR("Failed to attach slave cryptodev " - "%u.\n", slaves[i]); - return status; - } - - RTE_LOG(INFO, PMD, " Attached slave cryptodev %s\n", - dev->data->name); - } - - return 0; -} - -static int cryptodev_scheduler_create(const char *name, struct scheduler_init_params *init_params) { char crypto_dev_name[RTE_CRYPTODEV_NAME_MAX_LEN] = {0}; struct rte_cryptodev *dev; struct scheduler_ctx *sched_ctx; + uint32_t i; if (init_params->def_p.name[0] == '\0') { int ret = rte_cryptodev_pmd_create_dev_name( @@ -124,8 +101,50 @@ cryptodev_scheduler_create(const char *name, sched_ctx->max_nb_queue_pairs = init_params->def_p.max_nb_queue_pairs; - return attach_init_slaves(dev->data->dev_id, init_params->slaves, - init_params->nb_slaves); + for (i = 0; i < init_params->nb_slaves; i++) { + struct rte_cryptodev *slave_dev = + rte_cryptodev_pmd_get_named_dev( + init_params->slave_names[i]); + + /* if the slave dev exists in the system, attach it */ + if (slave_dev) { + int ret = rte_cryptodev_scheduler_slave_attach( + dev->data->dev_id, + slave_dev->data->dev_id); + + if (ret < 0) + return ret; + + CS_LOG_INFO("Scheduler %s attached slave %s\n", + dev->data->name, + init_params->slave_names[i]); + + continue; + } + + /* if the slave doesn't exist, store and attach later*/ + sched_ctx->init_slave_names[sched_ctx->nb_init_slaves] = + rte_zmalloc_socket( + NULL, + RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN, 0, + SOCKET_ID_ANY); + + if (!sched_ctx->init_slave_names[ + sched_ctx->nb_init_slaves]) { + CS_LOG_ERR("driver %s: Insufficient memory", + name); + return -ENOMEM; + } + + strncpy(sched_ctx->init_slave_names[ + sched_ctx->nb_init_slaves], + init_params->slave_names[i], + RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN - 1); + + sched_ctx->nb_init_slaves++; + } + + return 0; } static int @@ -214,21 +233,14 @@ parse_slave_arg(const char *key __rte_unused, const char *value, void *extra_args) { struct scheduler_init_params *param = extra_args; - struct rte_cryptodev *dev = - rte_cryptodev_pmd_get_named_dev(value); - - if (!dev) { - RTE_LOG(ERR, PMD, "Invalid slave name %s.\n", value); - return -1; - } if (param->nb_slaves >= RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES - 1) { CS_LOG_ERR("Too many slaves.\n"); return -1; } - param->slaves[param->nb_slaves] = dev->data->dev_id; - param->nb_slaves++; + strncpy(param->slave_names[param->nb_slaves++], value, + RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN - 1); return 0; } @@ -303,7 +315,7 @@ cryptodev_scheduler_probe(const char *name, const char *input_args) "" }, .nb_slaves = 0, - .slaves = {0} + .slave_names = { {0} } }; scheduler_parse_init_params(&init_params, input_args); diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c index f02506c..3384653 100644 --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c @@ -41,6 +41,46 @@ #include "scheduler_pmd_private.h" +/** attaching the slaves predefined by scheduler's EAL options */ +static int +scheduler_attach_init_slave(struct rte_cryptodev *dev) +{ + struct scheduler_ctx *sched_ctx = dev->data->dev_private; + uint8_t scheduler_id = dev->data->dev_id; + int i; + + for (i = sched_ctx->nb_init_slaves - 1; i >= 0; i--) { + const char *dev_name = sched_ctx->init_slave_names[i]; + struct rte_cryptodev *slave_dev = + rte_cryptodev_pmd_get_named_dev(dev_name); + int status; + + if (!slave_dev) { + CS_LOG_ERR("Failed to locate slave dev %s", + dev_name); + return -EINVAL; + } + + status = rte_cryptodev_scheduler_slave_attach( + scheduler_id, slave_dev->data->dev_id); + + if (status < 0) { + CS_LOG_ERR("Failed to attach slave cryptodev %u", + slave_dev->data->dev_id); + return status; + } + + CS_LOG_INFO("Scheduler %s attached slave %s\n", + dev->data->name, + sched_ctx->init_slave_names[i]); + + rte_free(sched_ctx->init_slave_names[i]); + + sched_ctx->nb_init_slaves -= 1; + } + + return 0; +} /** Configure device */ static int scheduler_pmd_config(struct rte_cryptodev *dev, @@ -48,7 +88,14 @@ scheduler_pmd_config(struct rte_cryptodev *dev, { struct scheduler_ctx *sched_ctx = dev->data->dev_private; uint32_t i; - int ret = 0; + int ret; + + /* although scheduler_attach_init_slave presents multiple times, + * there will be only 1 meaningful execution. + */ + ret = scheduler_attach_init_slave(dev); + if (ret < 0) + return ret; for (i = 0; i < sched_ctx->nb_slaves; i++) { uint8_t slave_dev_id = sched_ctx->slaves[i].dev_id; @@ -116,6 +163,13 @@ scheduler_pmd_start(struct rte_cryptodev *dev) if (dev->data->dev_started) return 0; + /* although scheduler_attach_init_slave presents multiple times, + * there will be only 1 meaningful execution. + */ + ret = scheduler_attach_init_slave(dev); + if (ret < 0) + return ret; + for (i = 0; i < dev->data->nb_queue_pairs; i++) { ret = update_order_ring(dev, i); if (ret < 0) { @@ -298,6 +352,11 @@ scheduler_pmd_info_get(struct rte_cryptodev *dev, if (!dev_info) return; + /* although scheduler_attach_init_slave presents multiple times, + * there will be only 1 meaningful execution. + */ + scheduler_attach_init_slave(dev); + for (i = 0; i < sched_ctx->nb_slaves; i++) { uint8_t slave_dev_id = sched_ctx->slaves[i].dev_id; struct rte_cryptodev_info slave_info; @@ -377,6 +436,16 @@ scheduler_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, dev->data->queue_pairs[qp_id] = qp_ctx; + /* although scheduler_attach_init_slave presents multiple times, + * there will be only 1 meaningful execution. + */ + ret = scheduler_attach_init_slave(dev); + if (ret < 0) { + CS_LOG_ERR("Failed to attach slave"); + scheduler_pmd_qp_release(dev, qp_id); + return ret; + } + if (*sched_ctx->ops.config_queue_pair) { if ((*sched_ctx->ops.config_queue_pair)(dev, qp_id) < 0) { CS_LOG_ERR("Unable to configure queue pair"); diff --git a/drivers/crypto/scheduler/scheduler_pmd_private.h b/drivers/crypto/scheduler/scheduler_pmd_private.h index 2f4feea..0597065 100644 --- a/drivers/crypto/scheduler/scheduler_pmd_private.h +++ b/drivers/crypto/scheduler/scheduler_pmd_private.h @@ -88,6 +88,9 @@ struct scheduler_ctx { char name[RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN]; char description[RTE_CRYPTODEV_SCHEDULER_DESC_MAX_LEN]; + + char *init_slave_names[RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES]; + int nb_init_slaves; } __rte_cache_aligned; struct scheduler_qp_ctx { -- 2.7.4