DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: <olivier.matz@6wind.com>
Cc: <dev@dpdk.org>, <shreyansh.jain@nxp.com>,
	<santosh.shukla@caviumnetworks.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v2 1/2] test/test: free mempool on exit
Date: Mon, 3 Apr 2017 14:30:01 +0530	[thread overview]
Message-ID: <1491210002-9519-1-git-send-email-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <1490955469-16216-1-git-send-email-shreyansh.jain@nxp.com>

From: Shreyansh Jain <shreyansh.jain@nxp.com>

mempool autotest was not freeing the mempools.

Fixes: 8ef772ae ("app/test: rework mempool tes")
Cc: stable@dpdk.org

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 test/test/test_mempool.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/test/test/test_mempool.c b/test/test/test_mempool.c
index b9880b3..d863885 100644
--- a/test/test/test_mempool.c
+++ b/test/test/test_mempool.c
@@ -500,15 +500,10 @@ static int test_mempool_single_consumer(void)
 	return 0;
 }
 
-static void
-walk_cb(struct rte_mempool *mp, void *userdata __rte_unused)
-{
-	printf("\t%s\n", mp->name);
-}
-
 static int
 test_mempool(void)
 {
+	int ret = -1;
 	struct rte_mempool *mp_cache = NULL;
 	struct rte_mempool *mp_nocache = NULL;
 	struct rte_mempool *mp_stack = NULL;
@@ -567,9 +562,6 @@ static int test_mempool_single_consumer(void)
 		goto err;
 	}
 
-	printf("Walk into mempools:\n");
-	rte_mempool_walk(walk_cb, NULL);
-
 	rte_mempool_list_dump(stdout);
 
 	/* basic tests without cache */
@@ -607,13 +599,14 @@ static int test_mempool_single_consumer(void)
 
 	rte_mempool_list_dump(stdout);
 
-	return 0;
+	ret = 0;
 
 err:
 	rte_mempool_free(mp_nocache);
 	rte_mempool_free(mp_cache);
 	rte_mempool_free(mp_stack);
-	return -1;
+
+	return ret;
 }
 
 REGISTER_TEST_COMMAND(mempool_autotest, test_mempool);
-- 
1.9.1

  parent reply	other threads:[~2017-04-03  9:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 10:17 [dpdk-dev] [RFC PATCH] test/test: support default mempool autotest Shreyansh Jain
2017-03-31 13:59 ` Olivier Matz
2017-03-31 14:11   ` Hemant Agrawal
2017-03-31 15:11 ` Santosh Shukla
2017-04-03  9:27   ` Hemant Agrawal
2017-04-03  9:00 ` Hemant Agrawal [this message]
2017-04-03  9:00   ` [dpdk-dev] [PATCH v2 2/2] " Hemant Agrawal
2017-04-04  5:57   ` [dpdk-dev] [PATCH v3 1/2] test/test: free mempool on exit Hemant Agrawal
2017-04-04  5:57     ` [dpdk-dev] [PATCH v3 2/2] test/test: support default mempool autotest Hemant Agrawal
2017-04-05  7:02       ` santosh
2017-04-05  7:21         ` Shreyansh Jain
2017-04-04 15:28     ` [dpdk-dev] [PATCH v3 1/2] test/test: free mempool on exit santosh
2017-04-05  9:35     ` [dpdk-dev] [PATCH v4 " Shreyansh Jain
2017-04-05  9:35       ` [dpdk-dev] [PATCH v4 2/2] test/test: support default mempool autotest Shreyansh Jain
2017-04-07 15:42         ` Olivier Matz
2017-04-19 13:10           ` Thomas Monjalon
2017-04-07 15:42       ` [dpdk-dev] [PATCH v4 1/2] test/test: free mempool on exit Olivier Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491210002-9519-1-git-send-email-hemant.agrawal@nxp.com \
    --to=hemant.agrawal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).