From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08E7D42B8C; Wed, 24 May 2023 13:14:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95368406BC; Wed, 24 May 2023 13:14:58 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id D6A2C4067E for ; Wed, 24 May 2023 13:14:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 64E123200979; Wed, 24 May 2023 07:14:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 May 2023 07:14:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1684926895; x=1685013295; bh=ViJ6EqRyXGQOeuB5trQXr7YyGJsj1HIUNfJ k/8HagOY=; b=Y7PUNdsHbusfka6WExxljJsYn7iUANo36no0w2GHBrmyiDxOY7t 5NsXl54Btr5h8x2ACpKmFN/9VnoYHMWbYZ4iEvUMUGGVhc6u0AERrTIwoCJFdbLd 4hdMHWYaAiu/NK8zdhmuDtU0hGF4fyv2oXby7Eo+kjGkMrpjdVxwfOW3Nb+m5aGd ORaK2D+/fFGcnRIHKPF59Lqe2G8gfvB7yG1V7jG+1m/L3N8ACzpAGHDK4mO0pIBH GlPJ+3VSU6pWLnjoh1xJlCbmNDX8C++4mh4tu+PS95I6fSe+J2Uv8Ybxv8xPpsLv mDtlCTO2WXbRtlb1HA3tIQimTZUS6l1kBAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684926895; x=1685013295; bh=ViJ6EqRyXGQOeuB5trQXr7YyGJsj1HIUNfJ k/8HagOY=; b=D6MwzDc2TXwyryqw+lgIaIioMXLoqjQNgeAC8/Wi/ocz1d6svA6 V1QMM+xMtc67UqqcWNsiazd2jKgWt/fFCeAfWun7FyJB0HpmSAkZEllGvz+Twtxu WbmezgwHotwOHidV+0EhovbHs/UlWfrq/RmW7VCQ5jyjy2KyF5LA/dPvVgX9FQdY jVYoNEQjjmBGpFTT/lTyrWzE1dcNBoFJGHEnYesCZyEGM3rWX4NoqbM2ARZPPRFU 1+5tWCs0Gn3oJXcTXFImQZOc0C62E5a/MZP1gLygm/cil/vQmcfLTjjQHRN0Ibqc hgp7wzYOFLE+ntqZgVjyK/qVFIw+FPH3GOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 May 2023 07:14:53 -0400 (EDT) From: Thomas Monjalon To: Nipun Gupta Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com Subject: Re: [PATCH v4 1/4] bus/cdx: introduce cdx bus Date: Wed, 24 May 2023 13:14:52 +0200 Message-ID: <14913442.JCcGWNJJiE@thomas> In-Reply-To: <20230508111812.2655-2-nipun.gupta@amd.com> References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230508111812.2655-1-nipun.gupta@amd.com> <20230508111812.2655-2-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, If I understand well, it is very specific to AMD devices. So I suggest adding "AMD" in title and descriptions. 08/05/2023 13:18, Nipun Gupta: > CDX bus supports multiple type of devices, which can be > exposed to user-space via vfio-cdx. > > vfio-cdx provides the MMIO IO_MEMORY regions as well as the > DMA interface for the device (IOMMU). > > This support aims to enable the DPDK to support the cdx > devices in user-space using VFIO interface. > > Signed-off-by: Nipun Gupta [...] > +CDX bus driver Can we name it "AMD CDX bus"? > +M: Nipun Gupta > +M: Nikhil Agarwal > +F: drivers/bus/cdx/ [...] > +* **Added CDX bus support.** Here as well and in other places, would be more precise to say "AMD CDX". > + > + CDX bus driver has been added to support AMD CDX bus, which operates > + on FPGA based CDX devices. The CDX devices are memory mapped on system > + bus for embedded CPUs. [...] > +#ifndef _BUS_CDX_DRIVER_H_ > +#define _BUS_CDX_DRIVER_H_ In general I prefer not adding underscores, as it is not required, and not really private. [...] > +#include > +#include > +#include > +#include > +#include > +#include I would bet some includes are not needed for this header file. > + > +#include > +#include > +#include > +#include > +#include > +#include [...]