* [dpdk-dev] [PATCH] net/i40e: fix default PFC setting
@ 2017-04-11 7:35 Jingjing Wu
2017-04-11 10:11 ` Hunt, David
0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2017-04-11 7:35 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu
To keep consistent with previous release, PFC need to be disabled
by default. This patch fixes it.
Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 6927fde..3e640b3 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
hw->local_dcbx_config.pfc.willing = 0;
hw->local_dcbx_config.pfc.pfccap =
I40E_MAX_TRAFFIC_CLASS;
- hw->local_dcbx_config.pfc.pfcenable =
- I40E_DEFAULT_TCMAP;
/* FW needs one App to configure HW */
hw->local_dcbx_config.numapps = 1;
hw->local_dcbx_config.app[0].selector =
--
2.4.11
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix default PFC setting
2017-04-11 7:35 [dpdk-dev] [PATCH] net/i40e: fix default PFC setting Jingjing Wu
@ 2017-04-11 10:11 ` Hunt, David
2017-04-11 11:24 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Hunt, David @ 2017-04-11 10:11 UTC (permalink / raw)
To: Jingjing Wu, dev
On 11/4/2017 8:35 AM, Jingjing Wu wrote:
> To keep consistent with previous release, PFC need to be disabled
> by default. This patch fixes it.
>
> Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 6927fde..3e640b3 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
> hw->local_dcbx_config.pfc.willing = 0;
> hw->local_dcbx_config.pfc.pfccap =
> I40E_MAX_TRAFFIC_CLASS;
> - hw->local_dcbx_config.pfc.pfcenable =
> - I40E_DEFAULT_TCMAP;
> /* FW needs one App to configure HW */
> hw->local_dcbx_config.numapps = 1;
> hw->local_dcbx_config.app[0].selector =
This also fixes an issue I was having occasionally where traffic was not
forwarded by testpmd on my platform. In those cases I was seeing ~4770
pps on one of the ports rather than the full rate (>20mpps).
A git bisect confirmed that this commit (6f0a707e5b55) was the source of
the issue.
Tested-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix default PFC setting
2017-04-11 10:11 ` Hunt, David
@ 2017-04-11 11:24 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-04-11 11:24 UTC (permalink / raw)
To: Hunt, David, Jingjing Wu, dev
On 4/11/2017 11:11 AM, Hunt, David wrote:
>
> On 11/4/2017 8:35 AM, Jingjing Wu wrote:
>> To keep consistent with previous release, PFC need to be disabled
>> by default. This patch fixes it.
>>
>> Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
>> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>> ---
>> drivers/net/i40e/i40e_ethdev.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 6927fde..3e640b3 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
>> hw->local_dcbx_config.pfc.willing = 0;
>> hw->local_dcbx_config.pfc.pfccap =
>> I40E_MAX_TRAFFIC_CLASS;
>> - hw->local_dcbx_config.pfc.pfcenable =
>> - I40E_DEFAULT_TCMAP;
>> /* FW needs one App to configure HW */
>> hw->local_dcbx_config.numapps = 1;
>> hw->local_dcbx_config.app[0].selector =
>
> This also fixes an issue I was having occasionally where traffic was not
> forwarded by testpmd on my platform. In those cases I was seeing ~4770
> pps on one of the ports rather than the full rate (>20mpps).
> A git bisect confirmed that this commit (6f0a707e5b55) was the source of
> the issue.
>
> Tested-by: David Hunt <david.hunt@intel.com>
Applied to dpdk-next-net/master, thanks.
(problem described by Dave added into commit log)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-11 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 7:35 [dpdk-dev] [PATCH] net/i40e: fix default PFC setting Jingjing Wu
2017-04-11 10:11 ` Hunt, David
2017-04-11 11:24 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).