DPDK patches and discussions
 help / color / mirror / Atom feed
From: Charles Myers <Charles.Myers@spirent.com>
To: <dev@dpdk.org>
Cc: Charles <Charles.Myers@spirent.com>
Subject: [dpdk-dev] [PATCH] net/mlx4: fix rx not working after mbuf alloc failure
Date: Thu, 13 Apr 2017 12:15:24 -1000	[thread overview]
Message-ID: <1492121724-105935-1-git-send-email-Charles.Myers@spirent.com> (raw)
In-Reply-To: <BY2PR1001MB11763C697502CAED06261E15EE020@BY2PR1001MB1176.namprd10.prod.outlook.com>

From: Charles <Charles.Myers@spirent.com>

Fixes issue where mlx4 driver stops receiving packets when mbuf
allocation fails in mlx4_rx_burst().

This issue appears to be caused because the code doesn't recycle the
existing mbuf to the sges array when mbuf allocation fails as is done
in the code right above it which handles (wc.status != IBV_WC_SUCCESS).

Copying the code from the above case fixes the issue.

Fixes: acac55f16412 ("mlx4: use MOFED 3.0 fast verbs interface for Rx
operations")

Signed-off-by: Charles Myers <Charles.Myers@spirent.com>
---
 drivers/net/mlx4/mlx4.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index aff9155..59d26fe 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -3169,6 +3169,8 @@ struct txq_mp2mr_mbuf_check_data {
 			/* Increase out of memory counters. */
 			++rxq->stats.rx_nombuf;
 			++rxq->priv->dev->data->rx_mbuf_alloc_failed;
+			/* Add SGE to array for repost. */
+			sges[i] = elt->sge;
 			goto repost;
 		}
 
-- 
1.7.9.5

  parent reply	other threads:[~2017-04-13 22:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1492069426-123358-1-git-send-email-Charles.Myers@spirent.com>
2017-04-13  7:52 ` Myers, Charles
2017-04-13 12:05   ` Adrien Mazarguil
2017-04-13 12:22     ` Ferruh Yigit
2017-04-13 12:28       ` Adrien Mazarguil
2017-04-13 22:15   ` Charles Myers [this message]
2017-04-14  9:58     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492121724-105935-1-git-send-email-Charles.Myers@spirent.com \
    --to=charles.myers@spirent.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).