From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C4440388F for ; Wed, 19 Apr 2017 15:40:29 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2017 06:40:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,221,1488873600"; d="scan'208";a="76259492" Received: from silpixa00381633.ir.intel.com (HELO silpixa00381633.ger.corp.intel.com) ([10.237.222.114]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2017 06:40:26 -0700 From: Fan Zhang To: dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, stable@dpdk.com Date: Wed, 19 Apr 2017 14:42:17 +0100 Message-Id: <1492609337-44733-1-git-send-email-roy.fan.zhang@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] crypto/scheduler: fix slave init attach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 13:40:30 -0000 Fixes: 881851676940 ("crypto/scheduler: improve commandline parsing") This patch fix the slaves attaching initially. Originally, the scheduler will try to attach the slaves passed by the cmdline option in the initial stage, this may break the sequence of the slaves inside the scheduler. Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/scheduler_pmd.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index f2a1d2a..2a92d1e 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -160,27 +160,6 @@ cryptodev_scheduler_create(const char *name, } for (i = 0; i < init_params->nb_slaves; i++) { - struct rte_cryptodev *slave_dev = - rte_cryptodev_pmd_get_named_dev( - init_params->slave_names[i]); - - /* if the slave dev exists in the system, attach it */ - if (slave_dev) { - int ret = rte_cryptodev_scheduler_slave_attach( - dev->data->dev_id, - slave_dev->data->dev_id); - - if (ret < 0) - return ret; - - CS_LOG_INFO("Scheduler %s attached slave %s\n", - dev->data->name, - init_params->slave_names[i]); - - continue; - } - - /* if the slave doesn't exist, store and attach later*/ sched_ctx->init_slave_names[sched_ctx->nb_init_slaves] = rte_zmalloc_socket( NULL, -- 2.7.4