DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type
Date: Thu, 20 Apr 2017 11:27:45 +0800	[thread overview]
Message-ID: <1492658865-30077-2-git-send-email-wei.zhao1@intel.com> (raw)
In-Reply-To: <1492658865-30077-1-git-send-email-wei.zhao1@intel.com>

The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4
in special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.

Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 3b9d60c..6f19b91 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1241,7 +1241,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
 	     hw->mac.type == ixgbe_mac_X550EM_x ||
 	     hw->mac.type == ixgbe_mac_X550EM_a) &&
 	    (rule->ixgbe_fdir.formatted.flow_type ==
-	     RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) &&
+	     IXGBE_ATR_FLOW_TYPE_IPV4) &&
 	    (info->mask.src_port_mask != 0 ||
 	     info->mask.dst_port_mask != 0)) {
 		PMD_DRV_LOG(ERR, "By this device,"
-- 
2.9.3

  reply	other threads:[~2017-04-20  3:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  3:27 [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Wei Zhao
2017-04-20  3:27 ` Wei Zhao [this message]
2017-04-21  2:48   ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Lu, Wenzhuo
2017-04-27  6:01     ` Zhao1, Wei
2017-04-21  2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27  6:07   ` Zhao1, Wei
2017-04-27  6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
2017-04-27  6:34   ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-27  7:14     ` Lu, Wenzhuo
2017-04-27  7:15   ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27  9:17     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492658865-30077-2-git-send-email-wei.zhao1@intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).