From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0080.outbound.protection.outlook.com [104.47.41.80]) by dpdk.org (Postfix) with ESMTP id A13302BF5; Tue, 25 Apr 2017 09:29:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VkaFEfmYcyORQosLnifXF1lu7cNnzJpavY1Se4U0LmA=; b=ROfx3T+S6e+gFvWyTrFGggKtoaLGX4FdP3HS0Dj7OBT39Vatd2ntCWgKIokmzBpYQxadxjOTLJQOhrKxQOqVcVFhf4VLm1HkzFo3C+0DrW8E0QyIxhZQ8fiCHOUlCwqvvBY0v+TKA8O3UrTEVF3RLhabowVTqQ9B1ylRyd0syzs= Received: from DM2PR07CA0045.namprd07.prod.outlook.com (10.141.52.173) by CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Tue, 25 Apr 2017 07:28:59 +0000 Received: from BN1BFFO11FD009.protection.gbl (2a01:111:f400:7c10::1:145) by DM2PR07CA0045.outlook.office365.com (2a01:111:e400:2414::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13 via Frontend Transport; Tue, 25 Apr 2017 07:29:00 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD009.mail.protection.outlook.com (10.58.144.72) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1047.9 via Frontend Transport; Tue, 25 Apr 2017 07:28:59 +0000 Received: from avsmtprelay01.qlc.com (10.1.112.194) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Tue, 25 Apr 2017 00:28:56 -0700 Received: from avluser05.qlc.com (avluser05.qlc.com [10.1.113.115]) by avsmtprelay01.qlc.com (Postfix) with ESMTP id 9F3168BF770A1; Tue, 25 Apr 2017 00:28:56 -0700 (PDT) Received: (from rmody@localhost) by avluser05.qlc.com (8.14.4/8.14.4/Submit) id v3P7SueR032057; Tue, 25 Apr 2017 00:28:56 -0700 X-Authentication-Warning: avluser05.qlc.com: rmody set sender to rasesh.mody@cavium.com using -f From: Rasesh Mody To: CC: Harish Patil , , Date: Tue, 25 Apr 2017 00:28:36 -0700 Message-ID: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39450400003)(39840400002)(39410400002)(39400400002)(2980300002)(428002)(189002)(199003)(9170700003)(50986999)(87636002)(38730400002)(6916009)(5003940100001)(189998001)(6666003)(47776003)(110136004)(86362001)(450100002)(101416001)(36756003)(8936002)(2906002)(356003)(4720700003)(48376002)(50226002)(50466002)(305945005)(105586002)(54906002)(81166006)(42186005)(2351001)(8676002)(5660300001)(4326008)(106466001)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2521; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD009; 1:YNEyxVixJx4nhoA5m27mh62MDR6nZy9vNurJCNAQEIZqz3zLNTkD+qEMDG3oBfvqHPq7NvJeV/HBW1AR4Q7kzwU5G7fPyfAK0wgqJ4mhaget2vVPiEHN/ifcn6HQAjxB+CDGrEzEJ5PiZWrdQ2DGGPXWRae0kJ1pK/foep53kAuIsHed9QKs7zjii9K4qc78zuL7peUSdmm+d9nwd7TZGT2sor0J7djTE90TzkRJOw+PXNlNyUpUR1Ib4pW6d8r1iCrxfZbtA910QEHdJtsy/JSOmuFhLJwOAGqisE9cHFcNpDmQmhamKtWE7wTViMw3X29SLBHKovujffrJ5Up/B7STqaF9pWck6CfqI3CKRLoGhVx6mhiiDZC8tngYcWBsZeutjlWUfIIjvymDBbrq1ywAQisdzmN1ExOkTllSkkKTODhif1Zz+EwR4Qs5iUw3JiKAZbtP/kb0tJvKdPDMIBGR3PshrA9/fhy43Onaq0Pzd8XjS4+HdkJu9AM3DIxf7s/nyq1yjECyhg7hOx3AUg== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3e4a000e-0504-4beb-99ba-08d48bacbd62 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 3:zVIm5BDOIyOrNTFus+U/Ro9aYNGFgY5DcOs/+Bo2kbAvQlh0913h9tjby4CBIA8BYPgeImpIMiCugOFIWhTa9sBfqSBisKPY6AoWWEk51QSjJA4lJ6xMcPyf9ICscF4ApxQRHpDonuc3wJQk7AIDKCI/LZIUv4mNS27JQJwuYvip9YTp7GJkL7qdLUQkF2EP2bN4Lzyt5c/dCyarHqeMKdLjY5eZcvyHE7MKgQ3Ug6dXo+x5cX7JVt8HwF2WQaHnihdhU6oFMCU7czOBZWV3T1rJQObp6Ft11fVZJh51R5GNeWQfg0TtXX/ytkyuscEbnS8Ba3HEO7T7LOYy0ZZTc9+2U5YNfIyYYVhtKKOrngR0XUy1LOJqR5BO6ZD1rWANGSs+JYkcM7Npm13KmZeXkdfch95QbraM9DP+sLIhfEqIDtuCAgZvq4EQ2Yh2xeuDPUFFbwJ8zqRcopA6NtxP3A==; 25:jSjVp07iuS2mwd4dtWTRNDr9OVrnX0f3O0aAZzV50PLMTKJhPeB0MSaexhnbxxKz3sfD61LCIAu0n/zpXw287+8EmLeMKeiFRrXM6vDtkSaaOB3bSibTpjn0aidtx/TpQqOuk4xdmloYBWc/OasX9uQoljD0Na0YRP2zSwO2ttXbSpgnFaAhbG/04Tnm/rJoJAhO2VsUZofIX/t75Trb42I4pWqhiTrCwqF7aJRcjBjl24rqY4aOkUueRnfMSffYLBYi0GKu7BshyNoBbJJpqnWUiJJli1ksyO2c/9b/pYDKZO+Prthzo4/6C0nM8W8t+VjKthCyzM7gn6fsevYQ1vV9hi/SQyBzCfOz6K1dVBXZaQ5L9EOzoNc4Gn5PCCc/Ngv0CKTJcGJhYiecJymv0mXYvxu17IF3RKhzP+0qGbUzn88jyRa+dWqPqhYsc+8ZXs8rgpm6DXVPCcI787p2ZA== X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 31:npGixafvuUu3PJCg8iz7NmYByTri8qbmCfA6fpsPAbqTMHnkNn+HUvkvSCxRfBezIo2RtvLEJJYsss3Oyykb8sgCBtlVwMjfQDHnxO32TnsS1ArX51gmGS53tWIbubpfGf6F5HHpl2tKZhvnvk1sxtPOhQDremFG7VbskZAcSOAdqWKF8l/OpYDLly1PvORcqo1Odc/a7+bN5e6bzdXBOxrpueV8VHOfKwGPhUPMWWqsAv/Rxo3PCTQHPhzw+zZp6ouRqUF+IFiKNZ5DW8AQVA==; 20:3njNie9LN9TEbDAXZc8IQw46cXxhOuNzMFjUlHxOSxV7y1Z7bk+ijDXgIrR9yolUf/a46URHsjypEecA5KV0RMiOkgn3DcXcMH2HS3znbGKL3pSKv9GmoMeyr93LkJKiTQC6AFP/s8CEQgH4aXeEd9pJ/B0kN8GHxHObqWfKXUpklXLDyRaUFOvrrU0jhJ0Ito0PzxYWH8UW5QFpUr3mnyw6D7J6J5YhJIcP3hxWyPQ712kj4L2viFoDoJF8J2JCb0E+4vlP4GqFafXxpBmFy4xHGWAZCICgduiwL0w0fpzdiDlmfjAbN9++5sl8xIQr2Rp6zTtNkdLtovEIzrZmvm8Bsd2xur5YGkqTDhWPRxUjC0NGzgqzCGGi0KQQ37+6eLTWoEqOTLHuvI1mcZsfQvHR+qewsX59O+at55fIhfq7vAv6H9aMyH7n/7fwv8015juAtB7AU0zFFNYqKJnNpFd+NQgwvLax/PZIm8HiM+sKKfJNuDI2CBdhLuN+l07V X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13015025)(8121501046)(5005006)(13017025)(13024025)(13023025)(13018025)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:CY1PR07MB2521; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 4:rbgach04kQY14FnkalrgHpDhOVJ+l9LU6WEY18jwvRzhRRW2OwqmtUgmOJda2ygcmrH+pypa/KG69gcOW4yhwm5C9PeNTW1b5GxJAy/eKP2WUmLba46nkySJRm3W8eZESoYQ6QSBrafXTDfezMGcxWwxY80rdMFFItDo7K7gCRCafpP6LC0xq8vhQmfMxK3CaYtcrJ0+bp4jC/FH4CtJ9G5QMUKxSb3qXmPrVP80p/HEfdrKObVetUsHjKNayUac22L2xQuvcSz0HCDgqW3EzOdjlC5XD2cGAWB9p9zkpOZSG2X7jn2nCRinF8PuLW5KZaD1UXJH99dGfQRX14sGjLT7CQIrmrPlmdlsNWNSxJya+VfMOhZnjhUMHeSsvEng/7S/TdJqtsVgpOenbyGPH7fSt80YJivfqcw4qR6wxdNIaxCsZHSdssrW6Pago5aPP1PLvUmhM2wGZyvQZxv6ESp/qXQlg2crVSh7ZmpL+8eKdwXv0i2pGZhzzbL52qiHPMOkTATHe6EkvuApoo/1S3NfgWxVd4ji00kLwx+pdRP7beCmYXUhxkhoOt0lDzN3ba8/rhrv58kC8DFs/vQsF1suFAo/km680REFC9QTcXXhYXDWaVpRhRXtYqDDesHiBkPfJiC5tlCSWU7wFIRhedMm6ID6Wsg/XryQB2JBwElkqgFDAftE467DAHHGSEYGflzNZDqDJCEa0q3JOThJ86M5q66DNJPR1QCnWHylVKdwEI5JbK3XwLeqrpHa9pW19HnpY3IhwacYVrmubD4aabOh887NIAqojGMpcUs1wWPRyrhVpqLxc8WmUYt6XZRv X-Forefront-PRVS: 0288CD37D9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2521; 23:QSBKWD6GPo7+gfNLIOqI/HJ166qcvAwe6qAQ3oyP5?= =?us-ascii?Q?uDb7Ukh/6efC06OEZK+klExE18Kn8WOvyl33ydHtcPvTs+fD16/3qji4k9FS?= =?us-ascii?Q?IA2af3SmAmXuKynkSkFCCyBNy9T8k1MUNI+iVj/qszstwyxPhLlSaAGoZHgh?= =?us-ascii?Q?WYlaEjlfH/tYihMzxPFuY9jQSCQ+6pIxNHvRXaACxnOGneGk/Au1JBXPaq8G?= =?us-ascii?Q?a/7L5W4TzU+kznSbnSdM4kL8vOGSHNr8Z8Ppg3OOkzB8YQJeNha5S5MipymV?= =?us-ascii?Q?Ij/8fBPguOq7cG6b4+pLOknG1g3bddwhvmLkI22MF+4mk6wWweyc2v3r7Fzv?= =?us-ascii?Q?6zVtc7xPoZovP9rcY5gAf4V/TMdZIp9Q5O+l4pqvrnwyoKZ9Zzqn7nnuQ/ne?= =?us-ascii?Q?1uS2/vZ1+I43AfZEhFYuqDVGYWnNKEROf+qc51IWv0OX2nYrAxUJXlmoTGW5?= =?us-ascii?Q?/dWinjTzynOph6q5uX6ODzNA73F/DOiX6HYhG3nSw9+tTyf75A5PfB6KCzxw?= =?us-ascii?Q?gzJV+7qXLfgMVjwkOOKvoFPRtQ19C0gao06/MEk/KPCI8ZXjZvwGaWZM1eha?= =?us-ascii?Q?tapTqkkcEhPE3FAV/xoHKYLOgkmMwTo1TtxFCeVBm7hqdNa6nLWTsA/FNKgT?= =?us-ascii?Q?gpAq6xbzoRDCalyue56ouiCo9WxQI3FIIDhVY70BgK6nQ7McGY7guViLtN9e?= =?us-ascii?Q?+H932DLi9/LYCa7W1tS8rFXF3vdu8mKyuVjzFXC3VOP8Cbr/uAQHWYX6+/FV?= =?us-ascii?Q?ren5nNqN1us8HytiZ7z1ubDAE/laILwURyGuObdj9fceCFmYFKFDVA34ruU4?= =?us-ascii?Q?qm0ulD6Yum0HTdJcJdmFCACMnmfkQJKTbCfCCMIyidNjAUuMHI0ZAK20rot7?= =?us-ascii?Q?GXBD/9tcL9EdF9FvsycKSHBz1zexHXdJrZ/pxSRSLgDY73h68iq1b0POqXtA?= =?us-ascii?Q?Er6aMmIXGygA9DNZZKMPuea9P8ZBOAzzyx8DKiGL1PL+m/rFcY8v7fEoec+u?= =?us-ascii?Q?subGjPt29r0Afcq9FxebOS3EFzPHvIqWuZa1T/pNJpir5BBoOO5dUiTPqll/?= =?us-ascii?Q?DaUvDk=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 6:HZaQurAE1VNeWVraOgvjGMM6GH94DMQJboWcEPu3mrtRgrXswB8ZDLTZO1vx4PsUY8yIJ7y9yNwG4meY4JJ++pQseTo4SAYNN+MW+z0rGU+/x/f1GA7XLfDyWnj01istjj1E19dDo2FKrgYq78qWke/XAmtjEiRg2UHmlZ2c2625paTTAudT/mUBL+Odni2sXdQHa2yAi1wjVvBm/GA+23CpsJoaxyRCZ2qVUlIKc+InZesSarAlXQWJmvIJVtjvF0hm/mhfeeExsq8dvVwkzRt5W2Ay9apQXnxGxkMKLMqbLdPBZdCs5BiiZ2sT6V3z+sHb5g+DXv6CEN0YAk5NMC4GTH9k7ilYEbac6mRix6cJcL7t3y0DixIkgEukp5l0pIWeuu8yx1IKthio7al5NQw/wCEK0C4gu7mVaPA3JLflFK7l/Kb0ZjyLF+qQv2tFdNTUwRRTCjME9mX2o1vgIbagH/j3m/633s++N5b+fzxlB6NkcrddRZ3l2z/e23ahV0CVU0Tec8KRVu/k87LErg==; 5:9bvwsKR2pLTBLhVzwWG+q5SQY+UMEgeOnovLbr7NXjH//TvDaegXOZfZ1/JbqmYPtn9EEyuGaEmdCBHwYn0Rq9nsEJtdf4xAM1dJTsKrT2A4Mygq7b+sKJLczOw3Uf/fkMHBTQYzUJKJYWyMBRWJRQ==; 24:G9A1Vm7EdlHOTUI4nEGykxEO+lONZ4G6FOTV2Z+/EIH892sUjxbWtSETIYDSAYC5dvxJkR6LtmTrek9bQCumCfyZVRLlUDBaiFlUoG7qNeQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 7:KUMmYmc+O7BPF31DTtaEnB52AHhCvtY3QC8XxdY94nEzKmvPh14igv1+v7AVD0zZ6/YuQdQpzLZ3ddDg5CUJeJfYUjRvLrF/orS0wQYqehhZaav2fN4xbDkzyk9xbXjW+DVN6pXGVau+4nXFE7ItwlWJKy6CfxjLdPOZnHaxf3HhaAnV6wh3a0lyYdH/P2EWEWBVS7NLZbbi+SJmvdXQvP4W5yFGXvGAdCNsT3L8Xemciw6HmJe63hbOPs4+0SbK5g5oXGNyOeutbSkdZaMjQaz9z/yBlOTshi8fdotdbWxr8BNbtl7tjTHxUQLba6UkXSH8nHJeIT8qPbWRhAV3EA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2017 07:28:59.0642 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2521 Subject: [dpdk-dev] [PATCH 01/11] net/qede: fix default MAC address handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 07:29:02 -0000 From: Harish Patil - In qede_mac_addr_set(), in order to configure default MAC address we first delete the existing MAC address before trying to add new one. During init time, there is no MAC filter to begin with, so trying to remove a non-existing MAC address causes a firmware exception. This can be prevented by internally calling qede_mac_addr_add() which has the checks in place to delete a MAC address only if it was added before. - Remove setting of the default MAC address from within qede_dev_configure() since rte_eth_dev_start() calls mac_addr_set() anyway. Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: stable@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index fbad2a6..b31a7df 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -551,8 +551,6 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn, { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); - struct ecore_filter_ucast ucast; - int rc; if (IS_VF(edev) && !ecore_vf_check_mac(ECORE_LEADING_HWFN(edev), mac_addr->addr_bytes)) { @@ -562,29 +560,7 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn, return; } - /* First remove the primary mac */ - qede_set_ucast_cmn_params(&ucast); - ucast.opcode = ECORE_FILTER_REMOVE; - ucast.type = ECORE_FILTER_MAC; - ether_addr_copy(&qdev->primary_mac, - (struct ether_addr *)&ucast.mac); - rc = ecore_filter_ucast_cmd(edev, &ucast, ECORE_SPQ_MODE_CB, NULL); - if (rc != 0) { - DP_ERR(edev, "Unable to remove current macaddr" - " Reverting to previous default mac\n"); - ether_addr_copy(&qdev->primary_mac, - ð_dev->data->mac_addrs[0]); - return; - } - - /* Add new MAC */ - ucast.opcode = ECORE_FILTER_ADD; - ether_addr_copy(mac_addr, (struct ether_addr *)&ucast.mac); - rc = ecore_filter_ucast_cmd(edev, &ucast, ECORE_SPQ_MODE_CB, NULL); - if (rc != 0) - DP_ERR(edev, "Unable to add new default mac\n"); - else - ether_addr_copy(mac_addr, &qdev->primary_mac); + qede_mac_addr_add(eth_dev, mac_addr, 0, 0); } static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool action) @@ -925,10 +901,6 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) SLIST_INIT(&qdev->vlan_list_head); - /* Add primary mac for PF */ - if (IS_PF(edev)) - qede_mac_addr_set(eth_dev, &qdev->primary_mac); - /* Enable VLAN offloads by default */ qede_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK | -- 1.7.10.3