From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0046.outbound.protection.outlook.com [104.47.42.46]) by dpdk.org (Postfix) with ESMTP id 819AE69D8; Tue, 25 Apr 2017 09:29:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=K1zlh664bleUbwVBbKSJW3z7ZpUkRqmFPLq5MVYclmM=; b=BZOA4aIzRnwhND6zSBigSweBpnOBvaLfsyXgPo2sf32OGNfHJ6MC7Fjdpgie08Ai8Ahyly9+3lZwlnHttzsd3JIDLsuYwqrAUk568xHazuj66UpqvyuQrQOazKAaJZkJjTLkw6nN9tKwmnenlPSkJ9wm2rR3HqS1tYp1b6pHe/I= Received: from SN1PR0701CA0056.namprd07.prod.outlook.com (10.163.126.24) by CY1PR0701MB1420.namprd07.prod.outlook.com (10.160.150.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Tue, 25 Apr 2017 07:29:48 +0000 Received: from BN1BFFO11FD023.protection.gbl (2a01:111:f400:7c10::1:121) by SN1PR0701CA0056.outlook.office365.com (2a01:111:e400:52fd::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13 via Frontend Transport; Tue, 25 Apr 2017 07:29:48 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD023.mail.protection.outlook.com (10.58.144.86) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1047.9 via Frontend Transport; Tue, 25 Apr 2017 07:29:47 +0000 Received: from avsmtprelay01.qlc.com (10.1.112.194) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Tue, 25 Apr 2017 00:29:32 -0700 Received: from avluser05.qlc.com (avluser05.qlc.com [10.1.113.115]) by avsmtprelay01.qlc.com (Postfix) with ESMTP id 87AA48BF770A8; Tue, 25 Apr 2017 00:29:26 -0700 (PDT) Received: (from rmody@localhost) by avluser05.qlc.com (8.14.4/8.14.4/Submit) id v3P7TQ67032105; Tue, 25 Apr 2017 00:29:26 -0700 X-Authentication-Warning: avluser05.qlc.com: rmody set sender to rasesh.mody@cavium.com using -f From: Rasesh Mody To: CC: Rasesh Mody , , Date: Tue, 25 Apr 2017 00:28:45 -0700 Message-ID: <1493105326-31984-10-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> References: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39400400002)(39410400002)(39850400002)(39450400003)(2980300002)(428002)(189002)(199003)(9170700003)(33646002)(6916009)(305945005)(2950100002)(2351001)(36756003)(110136004)(105586002)(48376002)(5003940100001)(38730400002)(106466001)(356003)(189998001)(4720700003)(5660300001)(86362001)(6666003)(50466002)(2906002)(42186005)(54906002)(47776003)(76176999)(50986999)(8676002)(87636002)(450100002)(50226002)(101416001)(4326008)(8936002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1420; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD023; 1:hRl8yPfg5GvBkFNAYcIu+Lg+PcbNcFSRU9mqTYn6hau06FD2g/KS9KhzitwnGXh6FX1sjE2djysArgZ7ID4adE2gEkqZoXrHRkK63Bi1ErzAmV4Yaub5/+X4kOTFWN60QWTABkmnNQnyePsNww7lCmNr5noSl6yJZ+ZR/GdmyTwmjua89bLsZKU9f2ylsa76lBQXQ/IPD2m5N428hOz+7EsHMZ4GeqZKUFJMdeUzuLRR4oZsaAypsswD9N3EH64ulgLbncrO91KMIXIOyXOLfw09q3/f4Jt6D0JfysT4gpzxscSznT7BjsgQoQ+tc8Q9YKvzCEhs71GmxQhOr3vqweaVvXI/mW9xd862IKu9lXvAT952bR/ISUh+IW4xJ6TXz6DcSe72bydjmIX+e6BH+Zxrorf5+Y4o8FpuUG6nAkHKT8FsWgWTgqdRWq/4zQ/nO//tIF9QJQzHtPqlc2k2Ga2ODCKaOfUmpGHI8rCPaJLX6b+mynWwZH48r3UYWO4CeoOJ6Mv4m4srJ0VMRtz5dA== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a157960-fa0f-47a4-9b6a-08d48bacda87 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:CY1PR0701MB1420; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1420; 3:0nalKufaOYB6Xi7On5TiBKoszhhSbqtkL0oiIBneM997vYUQiMa8gXLvenYggepfCxGEWF7x0df2daSXP2mAiDlcpGwF4WYrjsxiVV+cSyfe3b5TDP/muPg2/Ungix7dxrfEAYTdXgjMIy9PgQVlvy7QIwj+ZfNbRFEz5BYSrbf5WCa6089E9yhUuddjSx97xGgpfPbjYmSGsbotWItjd1EGnEwBn6QNJeefn5ld3TWnHq6+kspRca5OBpLBB8D/PPcPTvR71M/Nq8h8yRYy763vyWMj0ZLrnrUhKuWfTHq+pXVMu/Vb0vBX7pjWHVatTQ15ObES6Eg5IS2dq1YnOFAVPUCjkVOKuL5GrF4L3kYyhtlr5em5qopZOZLzbpso72KpqwgefnZhZHZ1Hmugh50FTEqO9BWZUC2P8RbYenPtmjE+Vigv/svXL8Z4x84jpuc8j+uKYeSWdgDy8WZSLQ== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1420; 25:2EtPrATnUPZuDaCp2Fu4ytLQL2nQG12ufl7umgq4VIuW1kfqbQw5iFzbHEX8lMlpAvWsIiUcKExOjxBWjSW/oOxkp8ZRr9S0YPdcJWdwvpi/HhY11gRp9UgaylT9zq86xfq6qfHPmoNZCstbNQG5hNDz38P8HK0mM11j7cXvA8+alPW4SOcljKL3tX6he9B/idIF3FVk3JlK2Nexe4pjjMRkno8aOUEFUls39kBSj67tdS/L+PkbUfQhHagkqime3cTKQU0edgm2SkXoMtiAaKCVUy73kvvSOM6VUAtiTIXeY8eOiAe5rDg/xraWiA2mlh8nmAuLEllmHlcY6HUm0BwNhbIcL1r+6ppcX955HZdqRlKSw7Fp3yNFlflUBOIvShdBnROx98sB7kjctY1Y+5IGWNzkI2SmNbTf5iiNistFs2woQGKAUEJkF4xpyDd0eylVXOKGAIn310aGFV36hw==; 31:bMvHnVGUqJca6E6u9b3iPiTmVaFtD+sCll+t5Zd9EMoLGZuJgMv6vcUPBwD9gC8/nHs0LVs2lGIoGNjdmdbZuZmzC0cb/dYcBoIPSYvDrCJ9fGsCPGej2kaVLNExdWPGgEku/hwEPgEDasVMDaP1aqAACVdO95kDZ7rxusZcrUpE/xHn/hd0SsEOajzILLz8lMfrx05Zuz8oc0y87BjmfosInvJIejjfIay1RhHM9lL5bhHBuOltkmsJ9lHZXl4JZrbFQyXdrwIjD8sVady/SpDUeyyhrxsI7Z4vAXOFMCc= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1420; 20:3PKUxcqVOGDwvzU0qtfdqX9GO5shIkmn4wHw9Q6afI9TIfQULuUHvuYFgCdHmlyPT5u7CFt2oJzhCXsOrL10AGgyPRlGC+CsxdssMunsXN/rSPwa8jRb8rfPSVLIvrhh+fZ5czeeCGOQ6SR7u9xEWkZeLpzjzykZf8n2O7UBDgBvRqm8Cab8Sn5fU7ytonGkmgieCemmzikc8akX03eUae5K3C47j3/gzgwk7GKXfA+Y7L/427McM3CtfkfGBnw1ErU+Mpx3AGfshIbgR5J51SLr6GsFLnkL56tOWBPqsC5qgUoVexRK9VOd5OIPDaqHPtKb9nenLwnC4DLkJ2tZop9QUBiliFz3DJK5AdzZcvRFpgRhQkcLfReIoOl3n5dx6pV6ApYgOKI8P7oWvGUMpDUqicfLhFhmxFs3JflcLfLoN9cJxiLPHWfNn/q74BuSFjBuRIXjv+YR1i83aRR1U3PXEem0O7Bf0AaSOk3n3TcpwE7MaF3MZNY4ToZyLKSw X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13017025)(8121501046)(5005006)(13015025)(13018025)(13023025)(13024025)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:CY1PR0701MB1420; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1420; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1420; 4:NBwUswLzrUpilQw5pU9Ms/PoFcKxSieEuo2O56rtdUs0TbaNs9YwWjG2G2PrczMiHlvVrFgrEEPofw7x3BAG3nL4B5/XN7dO+f4wyHRPJRTc0uzzhIl0UYTEATENIL4X03HTkJWzeP13j2kmLlBhQUxtZczZrp8X1KZEhikDLYoL394OKhh042QuF1E4m3xbFk+HORFd6VIM7G6VW3sDI690vZo1qXgCOK+ii9TyosZ9cOI8f2HYPcQMtsTZowZ5hvGLdNVhCiGIOV/rRsQQb8O5bXA5oe3/jsrHf3jcaXTLOUcerZcqcN9JV0tk9McZKEGTmldEjLSqsJIfHhgf9SbdPcHxzVQZw03myGxcw/3tLx0OS8hYHEKlcFrqNSy/3LyMQOg+eY2y9ZUfxY/j5U5vHvVcxCPVutYO5+4ksY1UK/oSYmEsOy7FDsekZZzO1osUFBSJYugciivDXMrC1G8VVC5/G5dYERJqZTHPjm3waPidD2TGArqXm7AF1UOChvL03wK7Wr3Et2onhB6E8KEaePisOY6KMbXMd1jUq3qdWoTNUSydsVa0XZhfV0W98I2nBCharqmKe8b71mSoBDqmnGq+yWNUJHJvPIoSDF1RSou5Dfc3yxTXhzK1aM6B3pAlsevxJZ4xuuPs9A1u9g55WNaw0m6j0qXVzt2dcgI/U/lngKIgNbPzSLv+8UCWZBFgk0RUkqFtYkkxRkMLbjK9fJTp9+EyM3IpNubP+F4yMznhFrSwk4Ei8t5DtacAqpSaYgIlB0/Mxkup9AaQO1YEWbzKCv5tMpsd93Sc2cN72ufSEF7k9r+gO2PFrIkJ X-Forefront-PRVS: 0288CD37D9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1420; 23:PZ7+3tjpLUI1tgzMjZS8cITJkaPAXKdR3hKzkiX?= =?us-ascii?Q?fgSyi/gc6D3t/axY2ayM2hWa8yRCaGSIU/g60XR/F+n5deelYxSxVtV5XTBa?= =?us-ascii?Q?1iPaMysd2KgeNnU+ecwNA/nc9p6c72qGA5m5c+e73GHkzboY/08+YBJ2hk7D?= =?us-ascii?Q?b0eK7pRv7CJX/I7Nk2TFxYFupDW81gtV7aFNDmu/BFODOmcomEzsP+IoHdkQ?= =?us-ascii?Q?bNj9gbrC3VbDv/LpAzx8C3jFYILUhJb13vbXnQn3tquot3Jhzk53fcshKpRS?= =?us-ascii?Q?+NQmEN8AgfdIVRvCe6q2kq9UeIm6/RUacaIHH/iPii72HfOyZwaSER6lszB/?= =?us-ascii?Q?RNWupAWvAsWLS5o47rPzFk3QatWKet/pzwf9sdtaMrA5xDRFTerH/XLipkHT?= =?us-ascii?Q?pw9Qqes7Zh6NPPo2/PN6PByWznITcFo6GGIEhgdl4YECUExzCrmlAXGaEyoN?= =?us-ascii?Q?wGrlcOgtPiLOxh1Xxcj71iZxty04kLct9rkAQxni/K8wWOiqa4DjUnnu3rvq?= =?us-ascii?Q?kswW43WjUka+nQPZw7TOm1xDRfj03ZGsUdbf4wc7rgLdHrnyPpnVxtsCE2d2?= =?us-ascii?Q?I/ETPHrn1GZJjybk/NaHUlx0SdkvqNm81lFvnVuMjdUGPAOUmExBHkZt+xCT?= =?us-ascii?Q?vzllKSB0CcpWIYTQ1wjeXNuiNBjT1aNzVAiZzSTlCuAC9yrDpSiW20uYg9dO?= =?us-ascii?Q?kxHoWyC23oSDrBdSWdYYWh7VNllRtlxigOHT4zETDe1tv2rAZehQ0XcGiDrJ?= =?us-ascii?Q?UbiLIUSkDtx8bWHuv+/NxcHSVU3kg5Pie/J+MxlddXxFQ3w5lkvzNIUw2HB4?= =?us-ascii?Q?0+T4CirHVu3sA+SfUHpZHMEGvmb9dHIjSU8prW2KEZcILtnSXZ4Z/uh/LFw3?= =?us-ascii?Q?r1yFZdp3+ACVCsPoE/xw9ECzYtrK8qtfd+FlpcMMPfZNrfVnWacEOANK4gZV?= =?us-ascii?Q?DgNxAmVcD7mLyb8IQgkJJw7AQQjdM/M5RN74JoOqsoaWkY7BMZnuQVNBeyHC?= =?us-ascii?Q?npW/xxSm9WR2KdhvNGHYX0aGmjgRYhD/j53Au8ZtXl8hAs3yu7szFIMntg6o?= =?us-ascii?Q?L2agfs3/JQewXoByW81GxDT7vV0pXyGCDpOX34709/ywvKkt4WCglbSW/JMd?= =?us-ascii?Q?M7EQSbFyhtK8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1420; 6:dJAF3LxZBc3oUw9RaClN+PHG8eugDP6UzrzrrQKenRHIgvFr5mBK3xL9avOqNhRuxtEyiBO+qUYaMKUNThYAklEtkjFegrTiJ5Usa/lqPvtopUUKl7boAYN+VY4S69N76m8AyF3vBIFyvWzv0Lb2KKK3p3u6vZuFoCsW7YNmuxx45gT8GaUrkyllaBWwcdmQ4Bhpl9jTCWjIpNOUNWuOnCFjswN/wT55Md07xhEkS3Xds7IRapI9RTLMzQKid2YuvTJIhdybsRzrMgZ+/GmCyOf4LaZhDCYy9rOgGCWfTcc2aQFzq3p6vL/2w/EkFyEaCtSNX2BhmWJTQtRBwyjtowHtWUyQeXvOFZojInD3L95AbwRJyWsCqh2NTYl6qiY4Ya8SIMWMfcWN5r6pEd7mNbYmJiHeeqhO78UY2rVjmN6TpxkWxFxn2DIzwTALP9H4oS5lAAAFHrPJ4U0L50yX3Hlc7COO8mMFYyMz7s6knOvul92eCqfSAG/88JCxbAxeTO7YPXqpUZwZtlyXygrtww==; 5:C7c+nrbQn3ru1YLjV9ycGcRpKluyLHgdYy0cEBVk6HLOO1oBh5zJhJ9oS/M1tdGs2HZ4I6tx7WvPDiFNpNETI0ulrY6oOTs6ZBZaA+EPm+UYu572GqHegyawxBR9YmY5288J2y0nebptAbp1RqoExQ==; 24:d/wn9UfHTfatGz09LCu5HBn/8yUW2b2/W34lF/tSwnifC1FzDhYRI1X2TYFRzTsLmp1/VhdwcgIDdlQL6r46SOQsQXdDZmIi9WsGJFbUEcc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1420; 7:jLO8bPu49DCs3EutUGh8XIF+m9A3IfqMJouTZ+0m3bKTiFukYCUHUj2f+6WnHZROmQVQvc7iL9jDM/c7vXiOSuUnOm7cSjVRZxOmM6fVU9QQnLIIXRIuKe+2LdOLjHypTlEy+MSCg7iLnu9QBuIN4RJ+sToFBEfHSQliWWT6/nyryyUXytFupHa3IzNCK3HujDONRrhjEs8L1rwP8f1rR60IEe3RJFhBp+VakAldJr0FJV5vqP5QJUE4MP3chdl4pDiqUIOAM7dhHFaYpPMbGlyRocdlH255q/5NUprjnaX2TR6Dn2Mvs+jatw0CXM32zBazMYAd/B7yqh3CpOavuQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2017 07:29:47.9606 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1420 Subject: [dpdk-dev] [PATCH 10/11] net/qede/base: fix find zero bit macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 07:29:52 -0000 Use appropriate operater for if condition Coverity issue: 1379399 Coverity issue: 1379404 Fixes: ec94dbc57362 ("qede: add base driver") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/qede/base/bcm_osal.c b/drivers/net/qede/base/bcm_osal.c index 28be958..3f895cd 100644 --- a/drivers/net/qede/base/bcm_osal.c +++ b/drivers/net/qede/base/bcm_osal.c @@ -98,9 +98,7 @@ inline u32 qede_find_first_zero_bit(unsigned long *addr, u32 limit) u32 nwords = 0; OSAL_BUILD_BUG_ON(!limit); nwords = (limit - 1) / OSAL_BITS_PER_UL + 1; - for (i = 0; i < nwords; i++) - if (~(addr[i] != 0)) - break; + for (i = 0; i < nwords && ~(addr[i]) == 0; i++); return (i == nwords) ? limit : i * OSAL_BITS_PER_UL + qede_ffz(addr[i]); } -- 1.7.10.3