From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0069.outbound.protection.outlook.com [104.47.34.69]) by dpdk.org (Postfix) with ESMTP id 296AC5A6A for ; Tue, 25 Apr 2017 09:29:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ajp54o8uFEu3SIoUW7AN99Q4Dnb2IlTrCvolJ483IZQ=; b=a1t57KpiHSheBpN8zHfLSoBYmdWDK0g2WrK1/ok2RUEOCb5UI48BbYtHae5jmR0Ey+fHthq/iy1nfrpGTD5V44BVqDN/iLMQEc6d30yphJ9nCqIFKdOPqs76b08jHjL3QGvL0Jc2kVemGkpILxQTynE33xOhJVtUv6amE7ayCCo= Received: from SN1PR0701CA0046.namprd07.prod.outlook.com (10.163.126.14) by DM2PR0701MB1422.namprd07.prod.outlook.com (10.161.252.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Tue, 25 Apr 2017 07:29:32 +0000 Received: from BN1BFFO11FD023.protection.gbl (2a01:111:f400:7c10::1:155) by SN1PR0701CA0046.outlook.office365.com (2a01:111:e400:52fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12 via Frontend Transport; Tue, 25 Apr 2017 07:29:31 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD023.mail.protection.outlook.com (10.58.144.86) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1047.9 via Frontend Transport; Tue, 25 Apr 2017 07:29:31 +0000 Received: from avsmtprelay01.qlc.com (10.1.112.194) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Tue, 25 Apr 2017 00:29:26 -0700 Received: from avluser05.qlc.com (avluser05.qlc.com [10.1.113.115]) by avsmtprelay01.qlc.com (Postfix) with ESMTP id 423E18BF770A2; Tue, 25 Apr 2017 00:29:26 -0700 (PDT) Received: (from rmody@localhost) by avluser05.qlc.com (8.14.4/8.14.4/Submit) id v3P7TQCb032099; Tue, 25 Apr 2017 00:29:26 -0700 X-Authentication-Warning: avluser05.qlc.com: rmody set sender to rasesh.mody@cavium.com using -f From: Rasesh Mody To: CC: Harish Patil , Date: Tue, 25 Apr 2017 00:28:39 -0700 Message-ID: <1493105326-31984-4-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> References: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39850400002)(39840400002)(39450400003)(2980300002)(428002)(199003)(189002)(9170700003)(2906002)(2351001)(42186005)(106466001)(36756003)(8936002)(86362001)(575784001)(81166006)(8676002)(50226002)(76176999)(50986999)(101416001)(5003940100001)(50466002)(5660300001)(54906002)(87636002)(48376002)(4326008)(47776003)(6916009)(4720700003)(356003)(107886003)(6666003)(110136004)(38730400002)(189998001)(2950100002)(33646002)(105586002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0701MB1422; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD023; 1:P7a9mIvFOKnWuDuw+lzHWY/M+HJwHYNHKOHdxKgbfCasKQtglJQL2T0Sv0V7iGp1Y76SZS+zV2eojd1JX+pJB3btACWDQXWJM7icfHD7s+C4nZF+xuPo/JzrOoPeNZUGzNoa1ECly3hbqyEVh4EbmHIuB1w1E92E8dS703H0d85pRWmWTMpzViYDK3oPRe2RQPdaQlcHdSDROlobZVxVAk0ULuhvZuwPxQpT59QYMEitdYCu54mug8ELpMdMCmlj3hZc5ubEG4vZwGgpyZt2kwFGeLSqfJQp7wCaXSanIvdKHcXhzZHpuXDhKwYNi+1v2oRIdCB6kEM5e1hKMDM5c1g1Tx64LpFy4evsJSQ+w2THzVBTPNtAY801cWbgQOOCKum/13dLzxlJFpzjSvqp/uFP0fSLhPHJxDWY1L7zltC0mrOFffWPEARG+6g69Iw8DuGN0wLSiONT+FoLymMtI7id92DQ9VmuuoLWzM907h0LANxDfwX/An0oH+RPdZ1krqIXfVei9NTLP927/wa+kg== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f59f5b8-841c-4eaf-65c6-08d48bacd0ac X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:DM2PR0701MB1422; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1422; 3:JepjKEuU9+coghFrrubxq9qfdq9eX8eg+2W7+Vp2JCNhpBUpLjbyQBGZBfc+Wyz/D+AQ1Yy/eExVRjBxhPrBqpKwo7PQRwRk0pGaE4QpmFlxgb4tiXINejajQXeDCRQJR3ccdyfJdErBHo/J0k7r2/OAacj3P4A9Hq5CQmCmZ4yElZ2UChmkk5hi5eaT/vv6xQRddBiLMeTPcuBHKGGfMT8eLqVQgb4j2vr+PGKMSUq0vU2OxuSGpOfKbUKF3oMJGJMQAed/cbBHOu5fMX3WKuBrso3IH1yRN8S8bKV82Y0faKkgCk+QJPoBgxYb0dlAJ9BgijFFcp+ToTlyThxBU1dZJx23Mz+89mTry1W1oehPCaNYHNb9SysXgSXEMbggSmix+65Nj1BiqQV2dLkWNkJ1DMJeDfpXQ7saXqfsLt3SwMhpFZuBtzHTrZ55Q88dHJMMD7Jij3xjC1HQYgTMNg== X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1422; 25:w+xfWajVKER2aptHxxbpqdgi0GPkx9pPzk+RpkeHFnLPktHN6OWEAC0IYM/sSV2ce3eSG/w5dp+/sbJjsX4umSIUiX0dWYdgfLh5oMBs4kSjQD0NehLl+jc0k7Rh1fAC5+yYl0MZOdvENUigp+gP3zoEThYy3heS9OAGwLbSyGOxjZNaGz6+k+dYKwVyMEHN38issZ0jzvaLidfLphvDbNGcDyec/XcdIT0O26YsBvJSEcn7ennDKiJdmCd11N0Crp4KCTGw9TW4nnwJW6ZWVvl/sohS+VS5Su6IXNWP0B4zMwsIu58D4L/Pip4aZHU/kPEHgU2L+HHek+REA1FzhHkdDal0zJWNC7Q4YY9LG6t7atm9D2HXR0HYykOOLhot0mXg+cTizQlc9zZw/V8z7uqYimIP2DobkjBRf6TPz9CdrtN3ZNGPvMcxcSZ510o/96WZjH4e/IYCgTu+31EqHw==; 31:JTeeye2GDuL8qkBXKN65W78L8putES3i/su2QjIhatZmcoxlYTkrK4VhuSrw/fnHG4grtY+p7L5TsvKUUDqjx3Chdtfo+cvJPsFtGKPn9UJWPy2YWR6HkoVAKpDlrpsGOkAJ+6/nD8z+L8eQsrgfDmfmcV/tRpM2Jw/YhProfgCc7cPjrm8iElf5mPOvMoJv4CTo3MaPMFbf9bFghzVDWnAOXDoFp5rLNW18f482Inmgp21wsV/GRuMCawzoSvvO X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1422; 20:6ShaxE9OwA+7MGsJbFsS2ZwAzwrVdCpW1Gzyeg7CyjF7d6STlJH6tSj/ZzbcZE2eNNzvYe7iNyU66TF4w8xcO9OZLbR0Po84JJNe43b1jIqBzcH3F0A8QASCAZdJr+X9Ed9E3nYaYB4/GaDz4tnJNDpiUvaxmH4N2v1QCMtbf6bdxlCgRuCQs/babb8cPmHHuaX4eZ3DjCzpF7O5NgJ70WT0AFTfnRqesejVF0ByrFxVz1Uo6gH9BaFrrduIX9LXt4zBUXqnxYHqSjFpujhT3kNpZn1hXNwFPraYn6o4xdi3NgiHLLEv9Ik07HTOBHoFPbV/BpLhuI82FAmsqgeoNrhYF2YeIPTaHMUgrcqIZ/UrD4gHWTEKCB/nRKwg775MCHXNTcS/TAQg2VEoNAxw6IMj3hThwwubitGZU6DqfT0mreO9ShH/WVu1eCA6OulvNtry0XSsnRNlBEBpYnl9wdJZmk0Jo/l8y/+zFsELkWKzeb7dPQgCTpboXUp7qEk/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13015025)(13017025)(8121501046)(5005006)(13024025)(13023025)(13018025)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:DM2PR0701MB1422; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0701MB1422; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1422; 4:QxetCHWIHpbHaCu81bKfsfoUk01MwROGMzBAkkQrOO7BV++jn1g1v0tb/s25poLczX+C8XkPs7zfkons34+Ftbn167Eq5cLq9bwzDx43ycWY8OpHl4AFMH1iWAKhHDsZClgfEk5mFhnMfQSDyEh0Di0ha7FSFC2xiWqMz6FObAmfUcPS3WUJidb20U4DbqedjtK0a8XT9KRqeAXAUde+fXvkLQYnJ/GHHoj1zt9F1Uf8qX/9sQe9zrghm5bgT/dM5soRdO8J4cUT3qoe1/N7NRaVxeTJpi/O+WqUTJu92YkM/2pF9d6+9jdH5qHsiRBewVGku/3TJJ5kvW/MnGHuSGvXijQzs9Ua/Nj3SXGKhkbRlKw0IfJ1+9NHnw3H1D3C3QjTU0GjOiOBHHWs3cTqpJaT95uR6E+4KVDiQj5xUN1MPNVdK11TjLMQW5QJ9aaGYqvTRyeH+LzTP487zFgc+rQrTk3ZQqWjRPd7dmYmQzIRePOZdPzu5WMso0+BfQ7d0+HhLRSGaS/nlAoWECkRF9yxy4pXsZORUUN2we+wgAV3Dm8IfPDLInpZwOl8tL3iP0X+7upNZZoKe//SUsxS6jcqZeYhch0nt8sNX0f/2zIV4iTXY6rueljk6ri5QmXgvJI4I4IXy9pxJ/ESn5xFYDMg5ES+alVCH85sbaf0NknJwfyDI2ljXtmflXfeotIREMToKw40sguQa88DjkjnHVZvg1oRLn30vl0X86RBtH5iKzpZoFO0nJCK+Ws6PXjZAbwqJwjhOUyZOwt2T1Zm3Bh+qUBEwsxn7LKhLPPErjJrM3Jxwzo73ZUYFscPsO2z X-Forefront-PRVS: 0288CD37D9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR0701MB1422; 23:LIgYrTtx1rp6nGKGOp/ULOK9yNTX1ShM9wo/Iaz?= =?us-ascii?Q?5BE1crPY5nsAFIY8TgoBWCRT2iEBofnoOiQ1plEqkyFuiJDnbAt8gXCqvTZI?= =?us-ascii?Q?W2MGkHmKicJitOfjk2hOBEQYUHUUpP6L5gcC2xReAGbO9tmAPTlawUQd4EAd?= =?us-ascii?Q?ZEq5TJocXty+NG1xXgOfrgdujMC1DTu+YCwqU4D7eh1yrBb8evp7LZCNGiPE?= =?us-ascii?Q?S1LVeOVFmdyr+h/7ikyPlQjChc9ffTIP6FpGy8qx/SSVqs5F6AN3zxa7m3aA?= =?us-ascii?Q?OPJiyo9AEkwtlP5NPR2713lSj9n3ZUmjygbaVhjO1e0qnRwyKLxYgv2mFnku?= =?us-ascii?Q?/IG9XTq7cOsDPxcwMls9hcK9+j0ak7tJV9Oog4m2QNMw790j9MrZvsqPDjgJ?= =?us-ascii?Q?X4p3OQZ1srRzJvA7X0UnqakOBx/gP/Uv4UA3cM1VvVJiVm96GXYmX+jbkaAX?= =?us-ascii?Q?7WP1vf0ujAPxDiSrZAe5u6SzW045ssIJTgEJdUkERBWSibGrcyrMg4syWWpI?= =?us-ascii?Q?L2R/5+NSr4QUxhFF5cpxCelS8BdM4Gtx04dZw3gtxYEIdT4zjm4SqlKtGK65?= =?us-ascii?Q?wCgvA4PrzC5pA7wjN7d9Dv8hYOZjExav62VZJiT3SYCv2L5ZDATzlaAM63bR?= =?us-ascii?Q?dECLlWGx0ZqM/Hmqol9sFGZ0wK226+SjZyrgsmY06gNS+DUiRBdLufwdAt06?= =?us-ascii?Q?uAAyZQBZSph2pPngt0LyH35F/leCHCoUylKKRztJxvBcd6hRKaRKk5IcJPxv?= =?us-ascii?Q?2Ko18gzkQC/ng5xpfbQbpFrF9Et3MG+ruKeKv/y6ihZRwIDKgBVlnd0eG7X9?= =?us-ascii?Q?NV5thn6ucKE8E9bYukB9mfXZZq+3wmUcVZCCXZ3nZDhPjg3lJcRlS1Fb5AWP?= =?us-ascii?Q?31lF1Q+hP/Y/FwH1BVVXuFdK64p7zGOvzm265aqdRtPLpySMfAwyEbiGmIEA?= =?us-ascii?Q?y5ptpZkDE502tUFtbSGijA8MT9iZadZ7KSihOQtxcUo28T2HRFARfoDmN9MD?= =?us-ascii?Q?ekuAIpIrHBJ8Qiq5qogv+G1vZWwwTbcsucmkUfdWfDN8jLAj1hkK8nAF/emV?= =?us-ascii?Q?bsb1IAt3mSpr6l4Ylt+RTIjKVi3N9Y548nKqWZjkg49lnZoGn2p0EtoUEubc?= =?us-ascii?Q?DokIlcQuAvvNdloamfsmAhcjSTzFS3BOc?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1422; 6:t9Gu042lQV6qdjx92QrTweJiHobk0P61ANCjYLxUPRx1ZB08IkuzVdBf9S1j8B7kI47otc7S5qbSPorBOd6muaLsxQ6J/BaxXnSqCvmbKwAsh+v4d4MFaJ6MQKtZdvvFxO2vv23a2M+O7QAstjBB2e18bwpCqau4XHD4uXKuEFygLMZB5EtVCx7rHTWFa6akGyaQNNev4H6pt6LrAzrRPnBLcBiZho9zAJBGPF3C/kt8Pnt36E553wBHEwHNLispV7dBTr2ezWXBfLBpylet5A4XblsykTYyvhkriKrhPIVxOxjsQgdan5dduC/Nrn1fBucnIHD4LZSljNzyrsZRuUarDEKVKImcO7oClDuXvvXT5mwp8aaFvag4rospGhnuyAZilvG030dW8WxL5x9qX8FYc1gwEYxt3B4NDYs+PCfrQPBzK0CvMqOK437u6+3XnTX61PL/d5jr55LdcP6Y/ZKrRUAPCooTXW7IP4kxRQb28UJLUkiflCLvleSVS5deatRZ7yGJEwS6RL3h/O+fcQ==; 5:AYEZ48oISdVPlqnap8Jv7f/DDN6HA4oU87KB36zusTHi6u51Owxrzvq8xWqXlLTItcDnmBGZG03RkiOvXTVbL97RfcDG93pDQ5j+tPkjMbWAfuq+iej9GaM8w8HhcM89uEfjFG7sUha4Gk2ur+TmIw==; 24:jtgpJpuMg6ZyiFuVOLmjixf6Z/KvlliBZS7uCexaPxcYn/rt4hN7zAYRmXZjrsJCqlAhHpafublSwuJNo2Jock9+LSTRiGV7IRmhlI0whAM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1422; 7:gHcOQdx50Xp/NLfn1zrJi+4ZTd9fQrbGHtX3Ljpx+2QYqzEmV+fe6Ul/a5i0U2j7IAYBpWZBQv4b/TERw86XNO8MGT344HNDEQX3SD7MG3uiCNlCMWixdO7HPo1YWp2DYP0S9csg6U5NfMa+nbTHYnnMDgwELAeuoH+xNa8/TS4Dsz9wafnezO/TVgqlcIk3XvusCsZV/3f/e5V8GRFbgYW2VhDFVz2KCutP45ScO9mmJ2V+5/mfo/QMmBZPGvk6xDtpzGZp6sP3j+YjG+XLE2mRtcauPoNABjnQpbQ2u3a6p+tTzSR7MJ6aLL4w9PRBeglE+9SzGU4FUXrDcRJeZA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2017 07:29:31.3933 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1422 Subject: [dpdk-dev] [PATCH 04/11] net/qede: fix coverity detected defects X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 07:29:34 -0000 From: Harish Patil This defect is a functional issue where the RX CQE pointer remains uninitialized in the LRO code path which can cause null pointer exception while accessing VLAN or RSS hash value from CQE. Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads") Coverity issue: 143474 Signed-off-by: Harish Patil --- drivers/net/qede/qede_rxtx.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index ec045b0..b180c0b 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -991,6 +991,7 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags) uint8_t bitfield_val; uint8_t offset, tpa_agg_idx, flags; struct qede_agg_info *tpa_info; + uint32_t rss_hash; hw_comp_cons = rte_le_to_cpu_16(*rxq->hw_cons_ptr); sw_comp_cons = ecore_chain_get_cons_idx(&rxq->rx_comp_ring); @@ -1005,6 +1006,7 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags) packet_type = RTE_PTYPE_UNKNOWN; vlan_tci = 0; tpa_start_flg = false; + rss_hash = 0; /* Get the CQE from the completion ring */ cqe = @@ -1068,6 +1070,10 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags) offset = fp_cqe->placement_offset; len = rte_le_to_cpu_16(fp_cqe->len_on_first_bd); pkt_len = rte_le_to_cpu_16(fp_cqe->pkt_len); + vlan_tci = rte_le_to_cpu_16(fp_cqe->vlan_tag); + rss_hash = rte_le_to_cpu_32(fp_cqe->rss_hash); + htype = (uint8_t)GET_FIELD(bitfield_val, + ETH_FAST_PATH_RX_REG_CQE_RSS_HASH_TYPE); } else { parse_flag = rte_le_to_cpu_16(cqe_start_tpa->pars_flags.flags); @@ -1075,6 +1081,10 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags) offset = cqe_start_tpa->placement_offset; /* seg_len = len_on_first_bd */ len = rte_le_to_cpu_16(cqe_start_tpa->len_on_first_bd); + vlan_tci = rte_le_to_cpu_16(cqe_start_tpa->vlan_tag); + htype = (uint8_t)GET_FIELD(bitfield_val, + ETH_FAST_PATH_RX_TPA_START_CQE_RSS_HASH_TYPE); + rss_hash = rte_le_to_cpu_32(cqe_start_tpa->rss_hash); } if (qede_tunn_exist(parse_flag)) { PMD_RX_LOG(INFO, rxq, "Rx tunneled packet\n"); @@ -1121,24 +1131,18 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags) } if (CQE_HAS_VLAN(parse_flag)) { - vlan_tci = rte_le_to_cpu_16(fp_cqe->vlan_tag); ol_flags |= PKT_RX_VLAN_PKT; + rx_mb->vlan_tci = vlan_tci; } - if (CQE_HAS_OUTER_VLAN(parse_flag)) { - vlan_tci = rte_le_to_cpu_16(fp_cqe->vlan_tag); ol_flags |= PKT_RX_QINQ_PKT; + rx_mb->vlan_tci = vlan_tci; rx_mb->vlan_tci_outer = 0; } - /* RSS Hash */ - htype = (uint8_t)GET_FIELD(bitfield_val, - ETH_FAST_PATH_RX_REG_CQE_RSS_HASH_TYPE); - if (qdev->rss_enable && htype) { + if (qdev->rss_enable) { ol_flags |= PKT_RX_RSS_HASH; - rx_mb->hash.rss = rte_le_to_cpu_32(fp_cqe->rss_hash); - PMD_RX_LOG(INFO, rxq, "Hash result 0x%x\n", - rx_mb->hash.rss); + rx_mb->hash.rss = rss_hash; } if (unlikely(qede_alloc_rx_buffer(rxq) != 0)) { @@ -1185,10 +1189,12 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags) rx_mb->port = rxq->port_id; rx_mb->ol_flags = ol_flags; rx_mb->data_len = len; - rx_mb->vlan_tci = vlan_tci; rx_mb->packet_type = packet_type; - PMD_RX_LOG(INFO, rxq, "pkt_type %04x len %04x flags %04lx\n", - packet_type, len, (unsigned long)ol_flags); + PMD_RX_LOG(INFO, rxq, + "pkt_type 0x%04x len %u hash_type %d hash_val 0x%x" + " ol_flags 0x%04lx\n", + packet_type, len, htype, rx_mb->hash.rss, + (unsigned long)ol_flags); if (!tpa_start_flg) { rx_mb->nb_segs = fp_cqe->bd_num; rx_mb->pkt_len = pkt_len; -- 1.7.10.3