DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check
Date: Thu, 27 Apr 2017 14:34:05 +0800	[thread overview]
Message-ID: <1493274846-59784-1-git-send-email-wei.zhao1@intel.com> (raw)
In-Reply-To: <1492658865-30077-1-git-send-email-wei.zhao1@intel.com>

Remove a useless item type check for fdir flow rule.

v2:
-delete item type check of vlan

aFixes: 11777435c72 ("net/ixgbe: parse flow director filter")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ixgbe/ixgbe_flow.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 98e414a..59ddba6 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2305,27 +2305,10 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
 		rule->mask.vlan_tci_mask &= rte_cpu_to_be_16(0xEFFF);
 		/* More than one tags are not supported. */
 
-		/**
-		 * Check if the next not void item is not vlan.
-		 */
-		index++;
-		NEXT_ITEM_OF_PATTERN(item, pattern, index);
-		if (item->type == RTE_FLOW_ITEM_TYPE_VLAN) {
-			memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
-			rte_flow_error_set(error, EINVAL,
-				RTE_FLOW_ERROR_TYPE_ITEM,
-				item, "Not supported by fdir filter");
-			return -rte_errno;
-		} else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
-			memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
-			rte_flow_error_set(error, EINVAL,
-				RTE_FLOW_ERROR_TYPE_ITEM,
-				item, "Not supported by fdir filter");
-			return -rte_errno;
-		}
 		/* check if the next not void item is END */
 		index++;
 		NEXT_ITEM_OF_PATTERN(item, pattern, index);
+
 		if (item->type != RTE_FLOW_ITEM_TYPE_END) {
 			memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
 			rte_flow_error_set(error, EINVAL,
-- 
2.9.3

  parent reply	other threads:[~2017-04-27  6:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  3:27 [dpdk-dev] [PATCH " Wei Zhao
2017-04-20  3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-21  2:48   ` Lu, Wenzhuo
2017-04-27  6:01     ` Zhao1, Wei
2017-04-21  2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27  6:07   ` Zhao1, Wei
2017-04-27  6:34 ` Wei Zhao [this message]
2017-04-27  6:34   ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-27  7:14     ` Lu, Wenzhuo
2017-04-27  7:15   ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27  9:17     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493274846-59784-1-git-send-email-wei.zhao1@intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).