From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FBB4439B5; Wed, 24 Jan 2024 13:35:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F7EC40294; Wed, 24 Jan 2024 13:35:01 +0100 (CET) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id 197CB4026F for ; Wed, 24 Jan 2024 13:35:00 +0100 (CET) X-ASG-Debug-ID: 1706099699-09411a31068ba60001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id OIEEbi2wMSsZtQhW (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 24 Jan 2024 06:34:59 -0600 (CST) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id EE8BBDA4278; Wed, 24 Jan 2024 06:34:58 -0600 (CST) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id 7f_egnqi8ZQ4; Wed, 24 Jan 2024 06:34:58 -0600 (CST) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id A16A9DA41F8; Wed, 24 Jan 2024 06:34:58 -0600 (CST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net A16A9DA41F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1706099698; bh=IlaT/z7cEibp+Vj0CEKUmTSF7Ig+7Nzy9/W1OL8t8zQ=; h=Date:From:To:Message-ID:MIME-Version; b=ZSdV3vcSP9SW519aIw16tAFJjV7ZSmWHK1X5wnbH457Y0iSszINHDDM0Er6nazWHA vlyMaAmc4pmhODI9+NcPxMQVU3pbBmJutBUSvhHJmhVf+cgZcdlVenE+RTj8iJm+fd gcNJ7979sGf7DiSipYZOYKVBsT8VlYf2hLzZX9gmj32Nxu9ZLhWSIvPFsOPJdbUxQN p2jHKl0pFyJ9bMrLiRKCzLpqsUn0n5dRNFMBmHymdCiUO38J18RqZS+VZyIb2mblBQ y3YPvjwOj7smALaE/KfvwsEx+8oMtJKgaOCm2rUEdeyJ28YmnloZdR7JJWTdga1Usg wD8DV+jiOwcNQ== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id v-la2DepNEYq; Wed, 24 Jan 2024 06:34:58 -0600 (CST) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 8A926DA436B; Wed, 24 Jan 2024 06:34:58 -0600 (CST) Date: Wed, 24 Jan 2024 06:34:58 -0600 (CST) From: Lewis Donzis To: Ferruh Yigit Cc: Bruce Richardson , dev , Jochen Behrens , Yong Wang Message-ID: <1493532725.16647920.1706099698534.JavaMail.zimbra@donzis.com> In-Reply-To: <264c4296-e705-46b4-80dc-e7b5c7567ecd@amd.com> References: <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> <20240109142343.163814-1-bruce.richardson@intel.com> <529916588.1295809.1704816025297.JavaMail.zimbra@donzis.com> <264c4296-e705-46b4-80dc-e7b5c7567ecd@amd.com> Subject: Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC120 (Mac)/8.8.15_GA_4581) Thread-Topic: net/vmxnet3: fix use of interrupts on FreeBSD Thread-Index: eILVtMOkCX6DfiETJf9O5SuHtrv+1w== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1706099699 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1012 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.119876 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Did this get checked in? Just curious because I don't see it in 22.11.4 that was released yesterday, so wasn't sure when it would show up. Thanks, lew ----- On Jan 11, 2024, at 6:03 AM, Ferruh Yigit ferruh.yigit@amd.com wrote: > On 1/9/2024 4:00 PM, Lewis Donzis wrote: >> >> >> ----- On Jan 9, 2024, at 8:23 AM, Bruce Richardson bruce.richardson@intel.com >> wrote: >> >>> DPDK does not support interrupts on FreeBSD, so the vmxnet3 driver >>> returns error when enabling interrupts as it initializes. We can fix >>> this by #ifdef'ing out the interrupt calls when building for FreeBSD, >>> allowing the driver to initialize correctly. >>> >>> Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") >>> >>> Reported-by: Lewis Donzis >>> Signed-off-by: Bruce Richardson >>> > >> Tested-by: Lewis Donzis >> > > Acked-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks.