DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: jingjing.wu@intel.com, reshma.pattan@intel.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: disable latency stats by default
Date: Thu,  4 May 2017 17:28:48 +0100	[thread overview]
Message-ID: <1493915328-130956-1-git-send-email-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <1493730674-102633-1-git-send-email-pablo.de.lara.guarch@intel.com>

Disable latency stats gathering by default,
so there is not performance degradation if user
is not interested in them.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---

This patch depends on http://dpdk.org/dev/patchwork/patch/24064/

 app/test-pmd/testpmd.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 776b8dd..0a4f15d 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)
 		}
 #endif
 #ifdef RTE_LIBRTE_LATENCY_STATS
-		if (latencystats_lcore_id == rte_lcore_id())
+		if (latencystats_enabled != 0 &&
+				latencystats_lcore_id == rte_lcore_id())
 			rte_latencystats_update();
 #endif
 
@@ -2238,10 +2239,13 @@ main(int argc, char** argv)
 		rte_panic("Empty set of forwarding logical cores - check the "
 			  "core mask supplied in the command parameters\n");
 
-	/* Bitrate stats disabled by default */
+	/* Bitrate/latency stats disabled by default */
 #ifdef RTE_LIBRTE_BITRATE
 	bitrate_enabled = 0;
 #endif
+#ifdef RTE_LIBRTE_LATENCY_STATS
+	latencystats_enabled = 0;
+#endif
 
 	argc -= diag;
 	argv += diag;
-- 
2.7.4

  parent reply	other threads:[~2017-05-04 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 13:11 [dpdk-dev] [PATCH] " Pablo de Lara
2017-05-02 13:11 ` De Lara Guarch, Pablo
2017-05-04 16:28 ` Pablo de Lara [this message]
2017-05-06  1:10   ` [dpdk-dev] [PATCH v2] " Wu, Jingjing
2017-05-06  7:38     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493915328-130956-1-git-send-email-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).