DPDK patches and discussions
 help / color / mirror / Atom feed
From: <zhangsha.zhang@huawei.com>
To: <dev@dpdk.org>
Cc: <declan.doherty@intel.com>, <pawelx.wodkowski@intel.com>,
	<jerry.lilijun@huawei.com>, <caihe@huawei.com>,
	Sha Zhang <zhangsha.zhang@huawei.com>
Subject: [dpdk-dev] [PATCH] bond: update the NTT flag when partner's state changes from slow to fast
Date: Mon, 22 May 2017 15:52:11 +0800	[thread overview]
Message-ID: <1495439531-10608-1-git-send-email-zhangsha.zhang@huawei.com> (raw)

From: Sha Zhang <zhangsha.zhang@huawei.com>

According to the standard, state machine of lacp should transmit lacpdu
when partner's state changes from slow to fast, rather than from fast
 to slow.

Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 7b863d6..742fd44 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -435,7 +435,7 @@
 			 * In other case (was fast and now it is slow) just switch
 			 * timeout to slow without forcing send of LACP (because standard
 			 * say so)*/
-			if (!is_partner_fast)
+			if (is_partner_fast)
 				SM_FLAG_SET(port, NTT);
 		} else
 			return; /* Nothing changed */
-- 
1.8.3.1

             reply	other threads:[~2017-05-22  7:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22  7:52 zhangsha.zhang [this message]
2017-06-27 10:12 ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2017-05-22  7:44 zhangsha.zhang
2017-05-22  6:40 zhangsha (A)
2017-06-26 15:17 ` Declan Doherty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495439531-10608-1-git-send-email-zhangsha.zhang@huawei.com \
    --to=zhangsha.zhang@huawei.com \
    --cc=caihe@huawei.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=pawelx.wodkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).